Le 12/04/2012 18:41, Colomban Wendling a écrit :
Modified: wscript 1 files changed, 1 insertions(+), 0 deletions(-) =================================================================== @@ -346,6 +346,7 @@ def build(bld): bld.new_task_gen( source = 'geany.pc.in', dct = {'VERSION' : VERSION,
'DEPENDENCIES': 'gtk+-2.0 >= 2.16 glib-2.0 >= 2.20', 'prefix': bld.env['PREFIX'], 'exec_prefix': '${prefix}', 'libdir': '${exec_prefix}/lib',
I'm wondering if there is a way to get at least the version from the configuration? Like bld.conf.libs['GTK'].atleast_version or something? I haven't found how to do so, but maybe you'll know :)
Cheers, Colomban
On Thu, 12 Apr 2012 18:47:18 +0200, Colomban wrote:
Hi,
first, nice idea about making the dependency information more central!
Modified: wscript 1 files changed, 1 insertions(+), 0 deletions(-) =================================================================== @@ -346,6 +346,7 @@ def build(bld): bld.new_task_gen( source = 'geany.pc.in', dct = {'VERSION' : VERSION,
'DEPENDENCIES': 'gtk+-2.0 >= 2.16
glib-2.0 >= 2.20', 'prefix': bld.env['PREFIX'], 'exec_prefix': '${prefix}', 'libdir': '${exec_prefix}/lib',
I'm wondering if there is a way to get at least the version from the configuration? Like bld.conf.libs['GTK'].atleast_version or something? I haven't found how to do so, but maybe you'll know :)
Not completely sure what you mean by "from the configuration". From where exactly do you want to read the versions?
Do you want to read the line gtk_modules="gtk+-2.0 >= 2.16 glib-2.0 >= 2.20" from configure.ac? That would be a bit hackish but definetely possible and would make maintaing the versions easier, a bit less obvious the fact we are using two build systems...(yes, I know...).
If so, I could write a few lines to "parse" configure.ac :).
Regards, Enrico
Le 12/04/2012 22:36, Enrico Tröger a écrit :
On Thu, 12 Apr 2012 18:47:18 +0200, Colomban wrote:
Hi,
first, nice idea about making the dependency information more central!
Modified: wscript 1 files changed, 1 insertions(+), 0 deletions(-) =================================================================== @@ -346,6 +346,7 @@ def build(bld): bld.new_task_gen( source = 'geany.pc.in', dct = {'VERSION' : VERSION,
'DEPENDENCIES': 'gtk+-2.0 >= 2.16
glib-2.0 >= 2.20', 'prefix': bld.env['PREFIX'], 'exec_prefix': '${prefix}', 'libdir': '${exec_prefix}/lib',
I'm wondering if there is a way to get at least the version from the configuration? Like bld.conf.libs['GTK'].atleast_version or something? I haven't found how to do so, but maybe you'll know :)
Not completely sure what you mean by "from the configuration". From where exactly do you want to read the versions?
Do you want to read the line gtk_modules="gtk+-2.0 >= 2.16 glib-2.0 >= 2.20" from configure.ac?
No, I meant fetch the version info from the waf configure() step (lines 131-134). However we could simply put the package version info in a global and use it in both places.
That would be a bit hackish but definetely possible and would make maintaing the versions easier, a bit less obvious the fact we are using two build systems...(yes, I know...).
Well, although it'd make a GTK dependency version bump a little easier, it's so hackish I doubt it's a good idea because of the potential headache it it breaks at some point :)
Cheers, Colomban
If so, I could write a few lines to "parse" configure.ac :).
Regards, Enrico
On Thu, 12 Apr 2012 22:49:26 +0200, Colomban wrote:
I'm wondering if there is a way to get at least the version from the configuration? Like bld.conf.libs['GTK'].atleast_version or something? I haven't found how to do so, but maybe you'll know :)
Not completely sure what you mean by "from the configuration". From where exactly do you want to read the versions?
Do you want to read the line gtk_modules="gtk+-2.0 >= 2.16 glib-2.0 >= 2.20" from configure.ac?
No, I meant fetch the version info from the waf configure() step (lines 131-134). However we could simply put the package version info in a global and use it in both places.
Yeah, that sounds good, done in https://github.com/geany/geany/commit/012a904e7496699b792761c12385cd289d7b6f....
Regards, Enrico
Le 12/04/2012 23:10, Enrico Tröger a écrit :
On Thu, 12 Apr 2012 22:49:26 +0200, Colomban wrote:
I'm wondering if there is a way to get at least the version from the configuration? Like bld.conf.libs['GTK'].atleast_version or something? I haven't found how to do so, but maybe you'll know :)
Not completely sure what you mean by "from the configuration". From where exactly do you want to read the versions?
Do you want to read the line gtk_modules="gtk+-2.0 >= 2.16 glib-2.0 >= 2.20" from configure.ac?
No, I meant fetch the version info from the waf configure() step (lines 131-134). However we could simply put the package version info in a global and use it in both places.
Yeah, that sounds good, done in https://github.com/geany/geany/commit/012a904e7496699b792761c12385cd289d7b6f....
Great, looks good :)
Cheers, Colomban
Regards, Enrico