On Thu, 05 May 2011 07:45:43 -0700, Matthew wrote:
On 05/05/11 02:11, Frank Lanitz wrote:
My understanding was that this has been fixed and now is working also on Windows. What is pending here?
I don't think it ever got fixed/applied. Last I remember, Enrico said he will do in the next few days, and then I never heard anything more.
I'm so sorry (honestly). I didn't intend to forget it...
What's pending is the patch to fix the original Windows bug[1][2] and re-enabling the Split Window plugin for Windows build[3][4].
[1] http://git.geany.org/geany/tree/plugins/splitwindow.c#n310 [2] http://git.geany.org/geany/tree/plugins/splitwindow.c#n361 [3] http://git.geany.org/geany/tree/plugins/makefile.win32#n61 [4] http://git.geany.org/geany/tree/wscript#n355
Do you still have links to the patches for [1] and [2]? I feel a bit lost as we had a couple of different patches and approaches, IIRC. This is obviously my fault because I delayed it that long, sorry again. Though I hope you can assist me with the patches a bit before I commit the wrong one and we start from the beginning.
[3] and [4] are trivial enough.
Regards, Enrico
Le 08/05/2011 18:20, Enrico Tröger a écrit :
On Thu, 05 May 2011 07:45:43 -0700, Matthew wrote:
On 05/05/11 02:11, Frank Lanitz wrote:
My understanding was that this has been fixed and now is working also on Windows. What is pending here?
I don't think it ever got fixed/applied. Last I remember, Enrico said he will do in the next few days, and then I never heard anything more.
I'm so sorry (honestly). I didn't intend to forget it...
What's pending is the patch to fix the original Windows bug[1][2] and re-enabling the Split Window plugin for Windows build[3][4].
[1] http://git.geany.org/geany/tree/plugins/splitwindow.c#n310 [2] http://git.geany.org/geany/tree/plugins/splitwindow.c#n361 [3] http://git.geany.org/geany/tree/plugins/makefile.win32#n61 [4] http://git.geany.org/geany/tree/wscript#n355
Do you still have links to the patches for [1] and [2]? I feel a bit lost as we had a couple of different patches and approaches, IIRC. This is obviously my fault because I delayed it that long, sorry again. Though I hope you can assist me with the patches a bit before I commit the wrong one and we start from the beginning.
[3] and [4] are trivial enough.
AFAICT just now, by only taking the time to read mails in a hurry, it just need to re-apply the commits:
http://git.geany.org/geany/commit/?id=757654e14b40d85c95c50ab422e3bcd63fa7fd... http://git.geany.org/geany/commit/?id=1788dfa8dc6ba106a16069cf4ca79d3ee2a553...
that were reverted:
http://git.geany.org/geany/commit/?id=a653ffec79d2a3ee7f013577a4510d34e8fc82... http://git.geany.org/geany/commit/?id=f047c60826804c331b991011f4ec59ccf3e96e...
now we have a proper fix to the X primary selection (thanks again to Matthew ^^).
And don't take all the responsibility of the lag, I should have re-applied these too. And took 5 mins at least to answer Matthew's mail rather than thinking "I'll fix this as soon as I have the time and answer at the same time, can't take long"... but still not done :/
So I add my personal apologies.
Cheers, Colomban
(just gone back to some other urgent things)
On 05/08/11 10:08, Colomban Wendling wrote:
just need to re-apply the commits:
http://git.geany.org/geany/commit/?id=757654e14b40d85c95c50ab422e3bcd63fa7fd... http://git.geany.org/geany/commit/?id=1788dfa8dc6ba106a16069cf4ca79d3ee2a553...
Yep, that should do it.
Cheers, Matthew Brush
Le 08/05/2011 23:18, Matthew Brush a écrit :
On 05/08/11 10:08, Colomban Wendling wrote:
just need to re-apply the commits:
http://git.geany.org/geany/commit/?id=757654e14b40d85c95c50ab422e3bcd63fa7fd...
http://git.geany.org/geany/commit/?id=1788dfa8dc6ba106a16069cf4ca79d3ee2a553...
Yep, that should do it.
Applied again. I tested under Linux, and it works OK, no more selection problems, nor weird cursors. I haven't tested on Windows, but I guess that nothing changed on this side since Enrico tried it last time? Though if somebody have the time/courage/will to test it on Windows again, it'd be great :)
Cheers, Colomban
Am 09.05.2011 15:27, schrieb Colomban Wendling:
Le 08/05/2011 23:18, Matthew Brush a écrit :
On 05/08/11 10:08, Colomban Wendling wrote:
just need to re-apply the commits:
http://git.geany.org/geany/commit/?id=757654e14b40d85c95c50ab422e3bcd63fa7fd...
http://git.geany.org/geany/commit/?id=1788dfa8dc6ba106a16069cf4ca79d3ee2a553...
Yep, that should do it.
Applied again. I tested under Linux, and it works OK, no more selection problems, nor weird cursors. I haven't tested on Windows, but I guess that nothing changed on this side since Enrico tried it last time? Though if somebody have the time/courage/will to test it on Windows again, it'd be great :)
Will give it a try once a Windowsbuild with this change is available.
Cheers, Frank
On Mon, 09 May 2011 15:35:00 +0200, Frank wrote:
Am 09.05.2011 15:27, schrieb Colomban Wendling:
Le 08/05/2011 23:18, Matthew Brush a écrit :
On 05/08/11 10:08, Colomban Wendling wrote:
just need to re-apply the commits:
http://git.geany.org/geany/commit/?id=757654e14b40d85c95c50ab422e3bcd63fa7fd...
http://git.geany.org/geany/commit/?id=1788dfa8dc6ba106a16069cf4ca79d3ee2a553...
Yep, that should do it.
Applied again. I tested under Linux, and it works OK, no more selection problems, nor weird cursors. I haven't tested on Windows, but I guess that nothing changed on this side since Enrico tried it last time? Though if somebody have the time/courage/will to test it on Windows again, it'd be great :)
Will give it a try once a Windowsbuild with this change is available.
http://nightly.geany.org/win32/
Have fun.
(I manually started the nightly build to get this new version into the Windows build. I almost finished reworking the nightlies system and will announce it once it's all running again.)
Regards, Enrico
Just tried this with the nightlies on windows, and it doesn't crash or anything like that. None off the right click functions work in the split off window.
On 5/9/2011 1:01 PM, Enrico Tröger wrote:
On Mon, 09 May 2011 15:35:00 +0200, Frank wrote:
Am 09.05.2011 15:27, schrieb Colomban Wendling:
Le 08/05/2011 23:18, Matthew Brush a écrit :
On 05/08/11 10:08, Colomban Wendling wrote:
just need to re-apply the commits:
http://git.geany.org/geany/commit/?id=757654e14b40d85c95c50ab422e3bcd63fa7fd...
http://git.geany.org/geany/commit/?id=1788dfa8dc6ba106a16069cf4ca79d3ee2a553...
Yep, that should do it.
Applied again. I tested under Linux, and it works OK, no more selection problems, nor weird cursors. I haven't tested on Windows, but I guess that nothing changed on this side since Enrico tried it last time? Though if somebody have the time/courage/will to test it on Windows again, it'd be great :)
Will give it a try once a Windowsbuild with this change is available.
http://nightly.geany.org/win32/
Have fun.
(I manually started the nightly build to get this new version into the Windows build. I almost finished reworking the nightlies system and will announce it once it's all running again.)
Regards, Enrico
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Le 09/05/2011 20:25, Oliver Krystal a écrit :
Just tried this with the nightlies on windows, and it doesn't crash or anything like that. None off the right click functions work in the split off window.
Thanks for testing! Actually it wouldn't crash, but have a really weird display. If you didn't notice anything, it's OK :D
And yeah, currently the second editor is a lousy version of the Geany's one, with many features missing (though many less since Matthew gave it some love).
Cheers, Colomban
Am 09.05.2011 20:25, schrieb Oliver Krystal:
Just tried this with the nightlies on windows, and it doesn't crash or anything like that. None off the right click functions work in the split off window.
I can second this (Windows7 64Bit running 32Bit Geany) Also the copy from second window is not working, but the graphical issues seems to be gone.
Nice job!
Cheers, Frank
On Mon, 09 May 2011 15:27:53 +0200, Colomban wrote:
Le 08/05/2011 23:18, Matthew Brush a écrit :
On 05/08/11 10:08, Colomban Wendling wrote:
just need to re-apply the commits:
http://git.geany.org/geany/commit/?id=757654e14b40d85c95c50ab422e3bcd63fa7fd...
http://git.geany.org/geany/commit/?id=1788dfa8dc6ba106a16069cf4ca79d3ee2a553...
Yep, that should do it.
Applied again. I tested under Linux, and it works OK, no more selection problems, nor weird cursors. I haven't tested on Windows, but I guess
Awesome, thank you Colomban.
Regards, Enrico