Hi!
I just began to write a port of the Gedit plugin from Autovala as a plugin for Geany and while setting up my fork of the geany-plugins repository I had to change the text for the yourfancypluginname.m4 file mentioned in the HACKING file from
AC_DEFUN([GP_CHECK_YOURFANCYPLUGINNAME], [ GP_ARG_DISABLE([yourfancypluginname], [auto]) GP_STATUS_PLUGIN_ADD([yourfancypluginname],
[$enable_yourfancxpluginname])
AC_CONFIG_FILES([ yourplugin/Makefile yourplugin/src/Makefile ]) ])
to
AC_DEFUN([GP_CHECK_YOURFANCYPLUGINNAME], [ GP_ARG_DISABLE([yourfancypluginname], [auto]) GP_COMMIT_PLUGIN_STATUS([yourfancypluginname]) AC_CONFIG_FILES([ yourplugin/Makefile yourplugin/src/Makefile ]) ])
in order to make autogen.sh work. Is this a bug/error in the HACKING file or am I missing something?
Greetings, Philipp.
On 24 May 2014 22:39, Philipp Trommler ph.trommler@gmail.com wrote:
Hi!
I just began to write a port of the Gedit plugin from Autovala as a plugin for Geany and while setting up my fork of the geany-plugins repository I had to change the text for the yourfancypluginname.m4 file mentioned in the HACKING file from
AC_DEFUN([GP_CHECK_YOURFANCYPLUGINNAME], [ GP_ARG_DISABLE([yourfancypluginname], [auto]) GP_STATUS_PLUGIN_ADD([yourfancypluginname],
[$enable_yourfancxpluginname])
AC_CONFIG_FILES([ yourplugin/Makefile yourplugin/src/Makefile ]) ])
to
AC_DEFUN([GP_CHECK_YOURFANCYPLUGINNAME], [ GP_ARG_DISABLE([yourfancypluginname], [auto]) GP_COMMIT_PLUGIN_STATUS([yourfancypluginname]) AC_CONFIG_FILES([ yourplugin/Makefile yourplugin/src/Makefile ]) ])
in order to make autogen.sh work. Is this a bug/error in the HACKING file or am I missing something?
git bisect says some b4n who shall remain nameless changed GP_STATUS_PLUGIN_ADD to GP_COMMIT_PLUGIN_STATUS without updating HACKING :(
Cheers Lex
Greetings, Philipp.
Devel mailing list Devel@lists.geany.org https://lists.geany.org/cgi-bin/mailman/listinfo/devel
Hi,
Le 24/05/2014 14:39, Philipp Trommler a écrit :
[...] Is this a bug/error in the HACKING file or am I missing something?
Indeed it is an error, thanks for reporting this. It is now fixed, together with more comprehensive explanations on more complex checks, in https://github.com/geany/geany-plugins/commit/0d11adef3bd2d597219e470313723d...
Cheers, Colomban