Hi all.
I've just could not install shiftcolumn plugin from trunk on a clean system. In shiftcolumn.c sciwrappers.h is included, which is not installed since Geany r4366. The attached patch replaces includes in shiftcolumn.c with the single include file geanyplugin.h. After this change geany-plugins compiled successfully. The patch is against the latest trunk (that is, r1053).
Best regards, Eugene.
On Thu, 5 Nov 2009 00:35:35 +0300 Eugene Arshinov earshinov@gmail.com wrote:
I've just could not install shiftcolumn plugin from trunk on a clean system. In shiftcolumn.c sciwrappers.h is included, which is not installed since Geany r4366. The attached patch replaces includes in shiftcolumn.c with the single include file geanyplugin.h. After this change geany-plugins compiled successfully. The patch is against the latest trunk (that is, r1053).
Thanks. I also sent the author a patch but received no response. Should we apply the fix anyway?
Regards, Nick
Hi Nick.
On Thu, 12 Nov 2009 11:59:00 +0000 Nick Treleaven nick.treleaven@btinternet.com wrote:
On Thu, 5 Nov 2009 00:35:35 +0300 Eugene Arshinov earshinov@gmail.com wrote:
I've just could not install shiftcolumn plugin from trunk on a clean system. In shiftcolumn.c sciwrappers.h is included, which is not installed since Geany r4366. The attached patch replaces includes in shiftcolumn.c with the single include file geanyplugin.h. After this change geany-plugins compiled successfully. The patch is against the latest trunk (that is, r1053).
Thanks. I also sent the author a patch but received no response. Should we apply the fix anyway?
Regards, Nick
Hmm... Yes, I think you should apply it. Otherwise nobody would be able to install Geany from SVN on a clean system.
Best regards, Eugene.
On Thu, 12 Nov 2009 15:09:25 +0300 Eugene Arshinov earshinov@gmail.com wrote:
Thanks. I also sent the author a patch but received no response. Should we apply the fix anyway?
Regards, Nick
Hmm... Yes, I think you should apply it. Otherwise nobody would be able to install Geany from SVN on a clean system.
OK, applied.
Regards, Nick
On Thu, 12 Nov 2009 12:41:56 +0000 Nick Treleaven nick.treleaven@btinternet.com wrote:
Thanks. I also sent the author a patch but received no response. Should we apply the fix anyway?
Regards, Nick
Hmm... Yes, I think you should apply it. Otherwise nobody would be able to install Geany from SVN on a clean system.
OK, applied.
Actually I didn't apply the patch, just removed the offending include as this was the smallest fix. Obviously single includes are better, but I left that up to the author.
Regards, Nick
On Thu, 12 Nov 2009 12:43:56 +0000 Nick Treleaven nick.treleaven@btinternet.com wrote:
On Thu, 12 Nov 2009 12:41:56 +0000 Nick Treleaven nick.treleaven@btinternet.com wrote:
Thanks. I also sent the author a patch but received no response. Should we apply the fix anyway?
Regards, Nick
Hmm... Yes, I think you should apply it. Otherwise nobody would be able to install Geany from SVN on a clean system.
OK, applied.
Actually I didn't apply the patch, just removed the offending include as this was the smallest fix. Obviously single includes are better, but I left that up to the author.
Regards, Nick
OK, thanks.