Looks good, i like the idea of 'about:config'`s style. Is it possible to change value? And now about the requiring restart, i think that this problem can be soled simply if the variable name is prefixed for example with '*', I think that nobody change hidden preferences every 5 minutes ;) Nice try Mitko, go ahead!!!
________________________________ I should have copy and pasted the truth.
-------- Оригинално писмо --------
От: Dimitar Zhekov dimitar.zhekov@gmail.com
Относно: Re: [Geany-devel] Unhide preferences
До: Geany development list
Изпратено на: Събота, 2010, Октомври 23 17:36:45 EEST
Hi,
This is a screenshot of the (not yet complete) Various tab.
The main function is:
void stash_setup_treeview(GPtrArray *group_array, gboolean variable,
GtkTreeView *tree, GtkLabel *label, GtkContainer *container);
group_array - obvious
variable - display/edit the groups marked as "variable" [write_once]
or all.
tree - obvious
label - if not NULL, displays the currently selected setting name.
container - if not NULL, when a setting is selected, an edit widget is
created, based on the setting type and inserted into container. If
NULL, there is no editing.
Currentry prefs.c calls stash_setup_treeview(pref_groups, TRUE,
widgets-obtained-from-the-Preferences-dialog). But we may call it with,
say, an array of plugins groups and FALSE. :)
Hunting the VTE/vc usage took me some time, I'll call it a day.
Unfortunately, vc requires some fixing.
2010/10/24 Адриан Димитров dimitrov.adrian@gmail.com:
Looks good
Agree, well done.
i like the idea of 'about:config'`s style.
Is it possible to change value? And now about the requiring restart, i think that this problem can be soled simply if the variable name is prefixed for example with '*', I think that nobody change hidden preferences every 5 minutes ;)
The difficulty is that nothing currently identifies which prefs require restart, so the first version IMO should just have a fixed message saying restart if you change anything.
Cheers Lex
Nice try Mitko, go ahead!!!
I should have copy and pasted the truth.
-------- Оригинално писмо -------- От: Dimitar Zhekov dimitar.zhekov@gmail.com Относно: Re: [Geany-devel] Unhide preferences До: Geany development list Изпратено на: Събота, 2010, Октомври 23 17:36:45 EEST
Hi,
This is a screenshot of the (not yet complete) Various tab.
The main function is:
void stash_setup_treeview(GPtrArray *group_array, gboolean variable, GtkTreeView *tree, GtkLabel *label, GtkContainer *container);
group_array - obvious
variable - display/edit the groups marked as "variable" [write_once] or all.
tree - obvious
label - if not NULL, displays the currently selected setting name.
container - if not NULL, when a setting is selected, an edit widget is created, based on the setting type and inserted into container. If NULL, there is no editing.
Currentry prefs.c calls stash_setup_treeview(pref_groups, TRUE, widgets-obtained-from-the-Preferences-dialog). But we may call it with, say, an array of plugins groups and FALSE. :)
Hunting the VTE/vc usage took me some time, I'll call it a day. Unfortunately, vc requires some fixing.
-- E-gards: Jimmy
Вижте последните новини във Vesti.bg! _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
Hi, all,
This is the first working version of the Various Preferences tab.
The interface is currently in interface.c only. Somebody with Glade experience and Glade version 2, please create the interface properly. The top part should be the same as in the Keybindings tab, while below the list should be a (hbox? container?) with unbound label on the left, and the Reset button on the right. The widget names are: various_treeview, various_hbox (or _container), various_label and various_button.
---
A short overview of the changes:
StashPref.write_once is renamed to various and used by the "various" stash functions only. No special keyfile load/save.
The various stash groups are included in the prefs_dialog groups: configuration_add_pref_group(group, FALSE) -> TRUE.
prefs_show_dialog() fetches the various_ widgets from the prefs_dialog and passes them to stash_setup_treeview().
msgwin_*_visible are moved from load/save_dialog_prefs() to the hidden prefs in ui_init_pref(), where they belong.
statusbar_template default value is moved from add_statusbar_statistics () to ui_init_prefs(). So "statusbar_template" initialization is the same as for any other setting.
---
What remains:
Minimize the static variable "stv" usage, make it private to stash_setup_treeview() and pass it (or the relevant data) to singals using user_data, other implementation improvements (Nick?)
Create variables for the "build-menu" settings and include them in the dialog.
Cleanup VteConfig *vc usage and include the hidden VTE settings in the dialog.
Add a "Restart required" message.
Check which settings require restart and display the message for them only?
Document the new stash functions.
Your-favorite-wish-here. :)
Hi,
This is a more complete version of the Various Preferences. The interface is fixed (but still in interface.c only), deselecting an item works properly, the [build-menu] settings are added, the code is improved, and a minimal documentation is included.
What remains:
Cleanup the VteConfig *vc usage and include the hidden VTE settings.
Try to reproduce the interface in geany.glade :(
Check which settings require restart and display the message for them only? Is marking them one-by-one worth the effort?
Display the group name? Add a show_group_name flag? For example: stash_group_set_show_group_name(group, gboolean show_group_name).
Use ( ) true ( ) false radio buttons for the boolean settings?
On Tue, 26 Oct 2010 21:46:11 +0300 Dimitar Zhekov dimitar.zhekov@gmail.com wrote:
Hi,
This is a more complete version of the Various Preferences. The interface is fixed (but still in interface.c only), deselecting an item works properly, the [build-menu] settings are added, the code is improved, and a minimal documentation is included.
Thanks. I'll try to look at it soon.
What remains:
Cleanup the VteConfig *vc usage and include the hidden VTE settings.
Try to reproduce the interface in geany.glade :(
BTW if you don't like using Glade you can add the tab manually, like the VTE does. Maybe the interface.c code could be moved elsewhere.
Check which settings require restart and display the message for them only? Is marking them one-by-one worth the effort?
No, but perhaps there could be a group setting for this (if it fits in with your code).
Display the group name? Add a show_group_name flag? For example: stash_group_set_show_group_name(group, gboolean show_group_name).
Use ( ) true ( ) false radio buttons for the boolean settings?
I'll answer these later after testing the patch.
Nick
On Thu, 28 Oct 2010 18:23:32 +0100 Nick Treleaven nick.treleaven@btinternet.com wrote:
BTW if you don't like using Glade you can add the tab manually, like the VTE does. Maybe the interface.c code could be moved elsewhere.
What I don't like is the glade-2/glade-3 situation... Anyway, I recreated the interface with Glade, to the point that interface.c has only a single insignificant difference. So it's OK.
On Fri, 29 Oct 2010 20:57:52 +0300 Dimitar Zhekov dimitar.zhekov@gmail.com wrote:
BTW if you don't like using Glade you can add the tab manually, like the VTE does. Maybe the interface.c code could be moved elsewhere.
What I don't like is the glade-2/glade-3 situation... Anyway, I recreated the interface with Glade, to the point that interface.c has only a single insignificant difference. So it's OK.
Can you send the geany.glade patch then? Otherwise the changes will be lost in future.
Nick
On Tue, 2 Nov 2010 15:14:16 +0000 Nick Treleaven nick.treleaven@btinternet.com wrote:
Can you send the geany.glade patch then? Otherwise the changes will be lost in future.
Here. I included the full patch, because the widget number suffixes are different. Applies with some offsets, but is still OK.