On 04/11/15 14:19, Colomban Wendling wrote:
LGTM, although I'd probably set the column to NULL even before freeing the plugin just in case.
Thanks @Jiří for the fix.
Re the build failures: yeah, since a few days we can't seem to fetch the GTK3 bundle… it's not a biggie in practice as if all of Linux+GTK2, Linux+GTK3 and Windows+GTK2 work it should be fine and not require testing Windows+GTK3, but it's annoying. I'll see what we can do here.
Maybe it's worth to host the GTK bundle archives ourselves. I think the network traffic won't be a problem. But to do this we still need the original ZIP archive to e available first to download it to the server.
Or we just wait to win32builder.gnome.org come back.
Regards, Enrico
On 04/11/2015 22:21, Enrico Tröger wrote:
On 04/11/15 14:19, Colomban Wendling wrote:
Re the build failures: yeah, since a few days we can't seem to fetch the GTK3 bundle… it's not a biggie in practice as if all of Linux+GTK2, Linux+GTK3 and Windows+GTK2 work it should be fine and not require testing Windows+GTK3, but it's annoying. I'll see what we can do here.
Maybe it's worth to host the GTK bundle archives ourselves. I think the network traffic won't be a problem. But to do this we still need the original ZIP archive to e available first to download it to the server.
I was about to PR a change to do just that, but I got stuck at the same point: I don't seem to have a local copy of the bundle :/ I've got the GTK2 one but not the GTK3 one :(
Maybe someone else of us has it? Thomas maybe?
Regards, Colomban
Am 04.11.2015 um 23:55 schrieb Colomban Wendling:
On 04/11/2015 22:21, Enrico Tröger wrote:
On 04/11/15 14:19, Colomban Wendling wrote:
Re the build failures: yeah, since a few days we can't seem to fetch the GTK3 bundle… it's not a biggie in practice as if all of Linux+GTK2, Linux+GTK3 and Windows+GTK2 work it should be fine and not require testing Windows+GTK3, but it's annoying. I'll see what we can do here.
Maybe it's worth to host the GTK bundle archives ourselves. I think the network traffic won't be a problem. But to do this we still need the original ZIP archive to e available first to download it to the server.
I was about to PR a change to do just that, but I got stuck at the same point: I don't seem to have a local copy of the bundle :/ I've got the GTK2 one but not the GTK3 one :(
Maybe someone else of us has it? Thomas maybe?
I started working on a script that creates the bundle including all dependencies from an MSYS2 installation (there, pacman has all the dependency infos).
Before that script I sent Enrico a few bundles (created manually). Here' the last one (gtk 3.16.4), but I can't remember if it has all dependencies or not.
https://oc.tmartitz.de/index.php/s/x27UAHQ0T5f4Qik/download
I didn't finish the script, but I guess I should finish it off. Do we need it before 1.26?
Best regards