Hi,
Following the idea in "Proposed patch to fix issues with command line file loading", here is a rewritten load_startup_files(), which:
1. Always loads the CL project. Currently it's ignored if "Load files from the last session" is unchecked, which is certainly a bug.
(Well, almost always: if a primary instance is running and -i is not specified, the CL project should be open in the primary instance, but on my system that doesn't happen. Doesn't look like a problem with load_starup_files(), so ignoring it for now.)
2. Always loads the CL files. Presently, any files specified after the project file are ignored; I could not find a reason for this, other than the layout of the current load_startup_files(), and it's marked with ATM, aka "at the moment". Well, the moment came.
3. Ignores --no-session if specified together with a CL project and "Project based session files" is checked (it normally is). In this situation, the old implementation opens the project with an empty file list, which is then saved in the project - I believe nobody would want that. Attempting to "properly" (whatever that may be) apply -s to projects creates various problems.
4. Is cleaner, a bit shorter (except for the comments), and can be easily customized for things like XSM, preference to load the default session even if CL files are specified etc.
I'd like this thread to be for fixing the current startup behaviour only. If you want any new functionality, please open a new thread, or continue "Proposed patch to fix issues [...]". Thanks in advance.
Hi,
On 13 April 2011 03:34, Dimitar Zhekov dimitar.zhekov@gmail.com wrote:
Hi,
Following the idea in "Proposed patch to fix issues with command line file loading", here is a rewritten load_startup_files(), which:
- Always loads the CL project. Currently it's ignored if "Load files
from the last session" is unchecked, which is certainly a bug.
Agree its a bug if Project based session files is set.
(Well, almost always: if a primary instance is running and -i is not specified, the CL project should be open in the primary instance, but
Agree thats what should happen, agree it doesn't with 0.20
on my system that doesn't happen. Doesn't look like a problem with load_starup_files(), so ignoring it for now.)
- Always loads the CL files. Presently, any files specified after the
project file are ignored; I could not find a reason for this, other than the layout of the current load_startup_files(), and it's marked with ATM, aka "at the moment". Well, the moment came.
Good fix, "project session plus some" is a perfectly good use case.
- Ignores --no-session if specified together with a CL project and
"Project based session files" is checked (it normally is). In this situation, the old implementation opens the project with an empty file list, which is then saved in the project - I believe nobody would want that. Attempting to "properly" (whatever that may be) apply -s to projects creates various problems.
Agree CL project should override --no-session and particularly should not clear the project file list, should be documented though.
- Is cleaner, a bit shorter (except for the comments), and can be
easily customized for things like XSM, preference to load the default session even if CL files are specified etc.
I can't try it ATM but looks good.
Cheers Lex
On Wed, 13 Apr 2011 12:15:07 +1000 Lex Trotman elextr@gmail.com wrote:
- Always loads the CL project. Currently it's ignored if "Load files
from the last session" is unchecked, which is certainly a bug.
Agree its a bug if Project based session files is set.
With PBSF off, at least the CL project settings should be loaded - but they aren't if "Load _files_ [...]" is off. So it's always a bug.