On 4 August 2012 10:21, Matthew Brush mbrush@codebrainz.ca wrote:
On 12-08-03 10:05 AM, Dimitar Zhekov wrote:
On Thu, 2 Aug 2012 10:57:22 +1000 Lex Trotman elextr@gmail.com wrote:
So I think we should keep Dimitars patch available for as long as he cares to maintain it so individual users can add it if they want, but the variability makes it inappropriate to commit to Geany.
If the changes were properly guarded out and disabled by default at compile-time, I see no reason not to merge the patch into master. I haven't
My problem isn't so much with the patch, it worked fine last time I had a working DE. Although it probably should be broken into a few commits to separate some of the "preparatory" changes from the actual SM stuff. My concern is rather with the maintenance issues if it is in git master. Unfortunately I expect lots of "I turned it on for <some DE> and it didn't work but <firefox, gedit, etc> does, fix it waaa waaa waaa" if we did that.
really reviewed the changes in detail though. IMO, the patch tracker on sf.net is barely a step up from being local to Dimitar's hard-drive in terms of exposure and usefulness to general users.
Yes agree that the patch tracker isn't ideal, it probably should be a git branch that Dimitar can maintain and then it is more visible without increasing his workload.
Pretty much infinitely, Geany without sm would be a big downgrade to me. I'm not going to support the git branch though, and it's already out of date.
I thought the Git branch was Eugenes and he already said it could be removed??
If my memory is right, then removing it and applying the patch to a "new_sm" branch would be the way to go.
I don't mind keeping the Git branch up to date if it helps keep some exposure on this useful patch, but it seems I don't get emails when the patch tracker is updated, so I dunno. I'm "Monitoring" the patch tracker but apparently I wasn't "Watching" it, so maybe now I'll get emails when there's updates now that I'm "Watching" it (unless I also have to "Like" it or "Friend" it or something). Of course if you want me to take the Git branch down instead, I can do that too.
Its SF, you have to stand on one leg, spin around three times while the wind is in the southwest and sprinkle pixie dust, easy :)
Cheers Lex
Cheers, Matthew Brush
Geany-devel mailing list Geany-devel@uvena.de https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel