On 2014-04-27 22:41, Matthew Brush wrote:
On 14-04-27 01:08 PM, Colomban Wendling wrote:
Le 27/04/2014 21:24, Matthew Brush a écrit :
Yeah I guess AM_PROG_VALAC() just issues those warnings instead of failing as I'd have expected.
In a perfect world, the generated *.[ch] files would be distributed and when compiling (from tarball at least) no Vala compiler would be required.
GNOME folks just say that distributing generated files was a bad design idea.
That's the very reason why the absence of valac doesn't trigger a failure (hence disabling the plugin): because tarballs include the C sources, and then valac isn't required unless you want to change the Vala source.
I'm not sure what we can do here… maybe magically detect it's not a tarball and then require valac? Not sure.
One not great option would be to check-in the generated source.
Just require this little dependency that Vala is for everyone. Or consider that Git = non-tarball and do:
if test -d .git -a -z "$VALAC"; then AC_MSG_ERROR([valac is required to build from Git]) fi