Hi,
During the phase of removing code that is not relevant anymore since the dependency bump, I fatally came out to write_data_to_disk(). Now we can assume we have GIO, it may seem sensible to drop completely the C API file saving code...
...However, GIO saving seems to cause some problems on some complex situations:
https://sourceforge.net/tracker/?func=detail&atid=787791&aid=3220784... https://sourceforge.net/tracker/index.php?func=detail&aid=3184594&gr... https://sourceforge.net/tracker/index.php?func=detail&aid=3126535&gr...
(and maybe more -- at least one on IRC).
So I'm wondering: do we really want to drop the C API-using code path, or do we want to make it configurable (like safe file saving)?
Well, since I'm not completely sure of what causes the problems and what are the downsides (either I don't remember or I did not participate to the discussion...), I prefer to ask you what do you think/know/remember/whatever about this.
I join a sample patch that make GIO saving configurable (just like safe file saving) with it enabled by default, if anybody wants to check it out.
So, what's your opinion?
Cheers, Colomban