2011/5/29 Enrico Tröger enrico.troeger@uvena.de:
So I had and added the necessary bits, I hope.
Thanks, looks good here.
I verified the icon installation on Linux and it works. I couldn't test it on Windows as currently the SVN checkout on Windows is broken (see thread "GeanyPG breaks SVN checkout on Windows" for more information).
I haven't tested the plugin under Windows at all and suspect it will need some modifications in order to work.
Two remarks:
- why do you use these custom icons at all? At least the icons for
Reload, Collapse and Expand can be taken from the stock icons. Not exactly sure about "Follow active editor", maybe there is something appropriate on http://developer.gnome.org/gtk/2.24/gtk-Stock-Items.html. Using the stock icons has the big advantage that these are provided by the icon theme of the user, so they fit better than your custom icons. Just an idea.
This is what I originally did. The problem is that the icons are different with different themes and there aren't any icons that are _semantically_ close to what I need. For instance I use the + and - icons for expansion/collapsing the tree - these icons are GTK_STOCK_ADD and GTK_STOCK_REMOVE but under some themes they look completely different and don't look like expand/collapse at all. The only stock icon I could use is GTK_STOCK_REFRESH but it would look strange if different icons in the toolbar were displayed with different themes. The same applies for the file icons too.
- #include <geany/geanyplugin.h>is wrong. On my system it didn't work
neither with autotools nor with Waf. The include path is wrong, just omit the "geany" path part. Attached is a patch to fix this.
Applied, thanks. I install geany into standard paths so the headers appear under /usr/local/lib/geany and were found by the compiler.
Regards, Jiri