On Mon, 10 May 2010 13:23:28 +0300, Dimitar wrote:
Hi.
In geany-svn, in the Goto Line dialog, Cancel works the same way as OK. That's because on_go_to_line_activate() checks the result of dialogs_show_input_goto_line() for NULL, but the result is always a copy of either the new or the old/default text. Altering dialogs_show_input_goto_line() not to use NVL() seems to work.
Oops, copy&paste mistake. Still, I'm wondering a bit why I couldn't reproduce it on my system though by reading the code it must had happened as you described. Weird, maybe it's because of my compile flags.
While on that, why not make dialog_input static? It should never be used outside dialogs.
Thanks, both changes committed.
Regards, Enrico