On Fri, 14 Aug 2009 12:24:41 +0200, Cédric wrote:
Hi Enrico,
Thansk for your advices. As I never developped very much in C with header files I don't know what's the best... I just see in another plugin that it was done like that and thought that it was the right
It's not really wrong. Putting general header includes into header files just has the disadvantages that they are always included regardless of whether the .c files which include this header need the other includes in this header. This can slow down the compilation process, in this case it's probably not even noticeable but still. Another disadvantage is that you always include more than necessary, while having only the necessary header includes in the .c files is more cleaner and IMO easier to maintain. But it's probably a matter of taste.
For the line returns, I put it it the struct configuration, so it will be configurable when I create the Preferences panel :-)
But why? We already have such an option in Geany and you can easily use the value as I said in my pevious mail. Why do you want to add another option for that in your plugin. I think users would use the same value in your plugin as also in Geany itself. Furthermore while thinking about it, isn't it better at all just to use the same line ending characters as in the current file? Or could you just shortly describe what exactly happens when these newlines are inserted and why, maybe this helps to reduce my confusion. Thanks.
Regards, Enrico