On Mon, 8 Mar 2010 23:40:08 +0100, Enrico wrote:
On Mon, 8 Mar 2010 12:18:39 +0000, Nick wrote:
On Sun, 7 Mar 2010 19:20:37 +0100 Enrico Tröger enrico.troeger@uvena.de wrote:
You put a weird pattern: [public|protected|private|static]* If you wanted to group, you should use ()
I didn't want to group, we don't need to know the actual modifier, we just want to allow only this subset. And yes, it was a group before but there is just no need to.
I think Can is right, [] brackets are only for character ranges, not string matching. So () brackets are necessary for matching even when ignoring the group.
Just for the records:
Yup, we talked about that yesterday afterwards on IRC and once he told me about that mistake, it was clear.
I spent a little more time on this again hoping to get it fixed. In SVN r4828, I adjusted the regular expression for parsing PHP functions a bit and I think it works now as expected or at least better than before. All function definitions I tried (with static, public, ... modifiers and some without and so on) worked and I got the expected argument list as calltip.
Though, as muliple times mentioned before, I'm not a PHP guy. Feedback is welcome.
Regards, Enrico