On Mon, 28 Jun 2010 13:13:11 +0100 Nick Treleaven nick.treleaven@btinternet.com wrote:
On Sun, 27 Jun 2010 15:20:24 +0300 Dimitar Zhekov dimitar.zhekov@gmail.com wrote:
Hi,
Here is a slightly newer version of the $subject patch.
Support for %_ has been removed, it doesn't make sense if the number of spaces can not be set, and only makes the text harder to read.
OK.
The default status line text is _("line: %l / %n\t col: %c ..."), not _(GEANY_DEFAULT_STATUSBAR_TEMPLATE), for easier i18n.
Yes, I'm not sure that the former would work for translatation.
To preserve the status bar speed, I used only g_string_append(), as in the current code, instead of utils_string_replace_all(). There are more _append calls, but that can't be avoided.
Not sure that's necessary, I think it would be cleaner using utils_string_replace_first().
Your approach is probably good, but I'll move the switch loop into a separate function.
Also you need to preserve all comments as they are for the translators.
Here I noticed the RO comment got lost, I'll add it again.
Regards, Nick