On 26/06/2012 21:46, Nick Treleaven wrote:
On 26/06/2012 21:31, Nick Treleaven wrote:
On 26/06/2012 21:21, Nick Treleaven wrote:
MSYS does treat backslashes as escapes, and I think that is a worse problem than cmd.exe interpreting forward slashes as command options, as it can occur in more situations. I think we should use forward slashes throughout.
I expected something like that. OK, the "-b" version uses forward slashes only. It's stupid and less efficient - not that it matters on novadays machines. The command interpreters seem to tolerate forward slashes for an exact-match path.
I don't understand why you made these changes with a separate target for each data subdirectory. This is not clean enough IMO.
OK, I just got it:
copy src/* dest
The syntax of the command is incorrect.
I still don't think separate targets is acceptable though. I can at least apply the rest of the patch though.
Now applied without the install changes; thanks for the patch.
BTW you missed data/templates/files. Wouldn't using a single xcopy be more sensible to reduce bugs and maintenance?
I've now committed to master an install target similar to your first patch, but using xcopy for data. I used a DIRSEP variable:
$(CP) plugins$(DIRSEP)*.dll "$(DESTDIR)/lib"
I think because 'copy' takes /y switches the first path it sees must not use forward slashes. They are OK in the destination though.
Please test.