Le 06/10/2011 22:51, Enrico Tröger a écrit :
On Fri, 07 Oct 2011 00:44:58 +0400, Alexander wrote:
06.10.2011 20:19, Frank Lanitz пишет:
On Wed, 05 Oct 2011 17:30:23 +0400 Alexander Petukhovdevel@apetukhov.ru wrote:
[...]
as I discovered the point is that you have to include config.h in every file that contains translatable strings, actually #define GETTEXT_PACKAGE "geany-plugins" is the only line that is needed from it. Previosuly it worked without it somehow.
if GETTEXT_PACKAGE is not defined, textdomain(NULL) returns NULL, i.e. there is no textdomain set, with GETTEXT_PACKAGE it returns "messages" while I expected to see "geany-plugins" here.
I tried to understand how i18n is realized in Geany but I couldn't find any textdomain call in Geany sources.
2Enrico: every plugin that do not include config.h in a file with strings seems to be untranslated now. As I mentioned above it worked without it earlier so I suppose other plugins can also miss this include and therefore be untranslated but I didn't check.
So two ways so far:
- include config.h everywhere it is nessesary
- look up what has been broken till 0.20
Ah, thanks for investigation. Then this is probably caused by the change to not automatically include config.h in geany.h which happened some months ago (this was a change in Geany where it was wrong before). Plugins just "used" that wrong behaviour and now it shows how they are broken. So we probably need to review each plugin again for this issue.
+1
Any volunteers? :)
Actually, though boring, it should be easy. Check POTFILES and see whether all files listed here correctly include config.h at the top. I can do this if needed.
Cheers, Colomban