On Sat, 2 Nov 2013 23:41:08 +0400 Pavel Roschin roshin@scriptumplus.ru wrote:
I checked the code with cppcheck (version from git). Also I created gtk config for cppcheck - if you are interested in, you could help me to fill it to improve analysis: https://gist.github.com/scriptum/7282198
Next leak ../geany-plugins/scope/src/menu.c:461 flase-pos, but it's a bad pattern using pointer after free.
Checking if it pointed to anything other than NULL is pretty normal IMHO. Adding an extra temporary variable just to keep cppcheck happy is simple, but I don't see enough merit, sorry.