Branch: refs/heads/master Author: Jiří Techet techet@gmail.com Committer: Jiří Techet techet@gmail.com Date: Sun, 26 Jan 2025 20:57:25 UTC Commit: f54843ac4f341774bb44245791e1f0e86e717cc5 https://github.com/geany/geany/commit/f54843ac4f341774bb44245791e1f0e86e717c...

Log Message: ----------- Remove redundant sidebar_openfiles_select()

There is already sidebar_select_openfiles_item() which does more or less the same (plus tree expanding and scrolling to the given item which we probably always want).

Modified Paths: -------------- src/document.c src/sidebar.c src/sidebar.h

Modified: src/document.c 2 lines changed, 1 insertions(+), 1 deletions(-) =================================================================== @@ -658,7 +658,7 @@ static GeanyDocument *document_create(const gchar *utf8_filename)

notebook_new_tab(doc);

- sidebar_openfiles_select(doc); + sidebar_select_openfiles_item(doc);

ui_document_buttons_update();

Modified: src/sidebar.c 19 lines changed, 1 insertions(+), 18 deletions(-) =================================================================== @@ -1065,23 +1065,6 @@ void sidebar_openfiles_update(GeanyDocument *doc) }

-void sidebar_openfiles_select(GeanyDocument *doc) -{ - GtkTreeModel *filter_model = gtk_tree_view_get_model(GTK_TREE_VIEW(tv.tree_openfiles)); - GtkTreeIter filter_iter; - gboolean have_filter_iter; - - have_filter_iter = gtk_tree_model_filter_convert_child_iter_to_iter( - GTK_TREE_MODEL_FILTER(filter_model), &filter_iter, &doc->priv->iter); - - if (have_filter_iter) - { - GtkTreeSelection *sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(tv.tree_openfiles)); - gtk_tree_selection_select_iter(sel, &filter_iter); - } -} - - void sidebar_openfiles_update_all(void) { guint i; @@ -1138,7 +1121,7 @@ void sidebar_openfiles_set_filter(const gchar *filter) update_visibility(store_openfiles, NULL, FALSE); gtk_tree_view_expand_all(GTK_TREE_VIEW(tv.tree_openfiles)); if (doc) - sidebar_openfiles_select(doc); + sidebar_select_openfiles_item(doc); }

Modified: src/sidebar.h 2 lines changed, 0 insertions(+), 2 deletions(-) =================================================================== @@ -81,8 +81,6 @@ void sidebar_openfiles_add(GeanyDocument *doc);

void sidebar_openfiles_update(GeanyDocument *doc);

-void sidebar_openfiles_select(GeanyDocument *doc); - void sidebar_openfiles_update_all(void);

void sidebar_openfiles_set_filter(const gchar *filter);

-------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).