[geany/geany] 12b9f2: Fix double escaping of markup in bold labels (oops) - Commits

22 Sep 2016


      Branch:      refs/heads/master
Author:      Colomban Wendling ban@herbesfolles.org
Committer:   Colomban Wendling ban@herbesfolles.org
Date:        Thu, 22 Sep 2016 13:43:04 UTC
Commit:      12b9f27a795f7ec8c1faf6c225314a09b6c5f7af
             https://github.com/geany/geany/commit/12b9f27a795f7ec8c1faf6c225314a09b6c5f7...
Log Message:
-----------
Fix double escaping of markup in bold labels (oops)
2499b96ea1d1eb523733c95e7ec73af827b6032e fixed missing escaping of
markup text, but failed to remove explicit escaping from
ui_label_new_bold(), leading to dual escaping of bold labels.
Modified Paths:
--------------
    src/ui_utils.c
Modified: src/ui_utils.c
5 lines changed, 1 insertions(+), 4 deletions(-)
===================================================================
@@ -2849,12 +2849,9 @@ void ui_label_set_markup(GtkLabel *label, const gchar *format, ...)
 GtkWidget *ui_label_new_bold(const gchar *text)
 {
    GtkWidget *label;
-	gchar *label_text;
-	label_text = g_markup_escape_text(text, -1);
    label = gtk_label_new(NULL);
-	ui_label_set_markup(GTK_LABEL(label), "<b>%s</b>", label_text);
-	g_free(label_text);
+	ui_label_set_markup(GTK_LABEL(label), "<b>%s</b>", text);
    return label;
 }
--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

    