Revision: 2385 http://geany.svn.sourceforge.net/geany/?rev=2385&view=rev Author: eht16 Date: 2008-03-21 11:29:25 -0700 (Fri, 21 Mar 2008)
Log Message: ----------- Fix crash on Windows due to missing error message when a process spawning fails.
Modified Paths: -------------- trunk/ChangeLog trunk/src/win32.c
Modified: trunk/ChangeLog =================================================================== --- trunk/ChangeLog 2008-03-21 18:24:21 UTC (rev 2384) +++ trunk/ChangeLog 2008-03-21 18:29:25 UTC (rev 2385) @@ -14,6 +14,9 @@ * data/snippets.conf: Add missing colon to "for" snippet for Python and set cursor position (thanks mamaar on IRC). + * src/win32.c: + Fix crash on Windows due to missing error message when a process + spawning fails.
2008-03-21 Nick Treleaven <nick(dot)treleaven(at)btinternet(dot)com>
Modified: trunk/src/win32.c =================================================================== --- trunk/src/win32.c 2008-03-21 18:24:21 UTC (rev 2384) +++ trunk/src/win32.c 2008-03-21 18:29:25 UTC (rev 2385) @@ -902,6 +902,8 @@ if (!fSuccess) { geany_debug("win32_spawn: Create process failed"); + if (error != NULL) + *error = g_error_new(G_SPAWN_ERROR, G_SPAWN_ERROR_FAILED, "Create process failed"); return FALSE; }
@@ -1014,7 +1016,7 @@ if (bFuncRetn == 0) { gchar *msg = g_win32_error_message(GetLastError()); - geany_debug("CreateChildProcess: CreateProcess failed"); + geany_debug("CreateChildProcess: CreateProcess failed (%s)", msg); if (*error != NULL) *error = g_error_new(G_SPAWN_ERROR, G_SPAWN_ERROR_FAILED, msg); g_free(msg);
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.