[geany/geany] 546659: Make Go to Symbol commands show signature list (#3475) - Commits

8 May 2023


      Branch:      refs/heads/master
Author:      Nick Treleaven ntrel002@gmail.com
Committer:   GitHub noreply@github.com
Date:        Mon, 08 May 2023 11:44:00 UTC
Commit:      54665998383eb03c5565aa360ff56ed4f7792aa6
             https://github.com/geany/geany/commit/54665998383eb03c5565aa360ff56ed4f7792a...
Log Message:
-----------
Make Go to Symbol commands show signature list (#3475)
When there is more than one matching symbol.
For variables, show type.
For callables, show (at least) parameter list.
Show non-first item using italic `file:line:`.
Modified Paths:
--------------
    src/symbols.c
Modified: src/symbols.c
9 lines changed, 7 insertions(+), 2 deletions(-)
===================================================================
@@ -536,6 +536,7 @@ static const gchar *get_symbol_name(GeanyDocument *doc, const TMTag *tag, gboole
 }
+// Returns NULL if the tag is not a variable or callable
 static gchar *get_symbol_tooltip(GeanyDocument *doc, const TMTag *tag)
 {
    gchar *utf8_name = tm_parser_format_function(tag->lang, tag->name,
@@ -1508,14 +1509,18 @@ static void show_goto_popup(GeanyDocument *doc, GPtrArray *tags, gboolean have_b
    	GtkWidget *image;
    	gchar *fname = short_names[i];
    	gchar *text;
+		gchar *sym = get_symbol_tooltip(doc, tmtag);
+		if (!sym)
+			sym = g_strdup("");
    	if (! first && have_best)
    		/* For translators: it's the filename and line number of a symbol in the goto-symbol popup menu */
-			text = g_markup_printf_escaped(_("<b>%s: %lu</b>"), fname, tmtag->line);
+			text = g_markup_printf_escaped(_("<b>%s:%lu:</b> %s"), fname, tmtag->line, sym);
    	else
    		/* For translators: it's the filename and line number of a symbol in the goto-symbol popup menu */
-			text = g_markup_printf_escaped(_("%s: %lu"), fname, tmtag->line);
+			text = g_markup_printf_escaped(_("<i>%s:%lu:</i> %s"), fname, tmtag->line, sym);
+		g_free(sym);
    	image = gtk_image_new_from_pixbuf(symbols_icons[get_tag_class(tmtag)].pixbuf);
    	label = g_object_new(GTK_TYPE_LABEL, "label", text, "use-markup", TRUE, "xalign", 0.0, NULL);
    	item = g_object_new(GTK_TYPE_IMAGE_MENU_ITEM, "image", image, "child", label, "always-show-image", TRUE, NULL);
--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

    