Revision: 4124 http://geany.svn.sourceforge.net/geany/?rev=4124&view=rev Author: eht16 Date: 2009-08-25 21:23:14 +0000 (Tue, 25 Aug 2009)

Log Message: ----------- Improve parsing of PHP functions by requiring a valid modifier or whitespace before the 'function' keyword to ignore some false positives like function tags inside comments (patch by Harold Aling, thanks).

Modified Paths: -------------- trunk/ChangeLog trunk/tagmanager/php.c

Modified: trunk/ChangeLog =================================================================== --- trunk/ChangeLog 2009-08-25 16:55:56 UTC (rev 4123) +++ trunk/ChangeLog 2009-08-25 21:23:14 UTC (rev 4124) @@ -1,3 +1,12 @@ +2009-08-25 Enrico Tröger <enrico(dot)troeger(at)uvena(dot)de> + + * tagmanager/php.c: + Improve parsing of PHP functions by requiring a valid modifier or + whitespace before the 'function' keyword to ignore some false + positives like function tags inside comments + (patch by Harold Aling, thanks). + + 2009-08-25 Nick Treleaven <nick(dot)treleaven(at)btinternet(dot)com>

* data/filetypes.markdown:

Modified: trunk/tagmanager/php.c =================================================================== --- trunk/tagmanager/php.c 2009-08-25 16:55:56 UTC (rev 4123) +++ trunk/tagmanager/php.c 2009-08-25 21:23:14 UTC (rev 4124) @@ -76,8 +76,8 @@ "\2", "i,interface,interfaces", NULL); addTagRegex(language, "(^|[ \t])define[ \t]*\([ \t]*['"]?([" ALPHA "_][" ALNUM "_]*)", "\2", "d,macro,constant definitions", NULL); - addTagRegex(language, "(^|[ \t])function[ \t]+&?[ \t]*([" ALPHA "_][" ALNUM "_]*)", - "\2", "f,function,functions", NULL); + addTagRegex(language, "^[ \t]*((public|protected|private|static)[ \t]+)*function[ \t]+&?[ \t]*([" ALPHA "_][" ALNUM "_]*)", + "\3", "f,function,functions", NULL); addTagRegex(language, "(^|[ \t])(\$|::\$|\$this->)([" ALPHA "_][" ALNUM "_]*)[ \t]*=", "\3", "v,variable,variables", NULL); addTagRegex(language, "(^|[ \t])(var|public|protected|private|static)[ \t]+\$([" ALPHA "_][" ALNUM "_]*)[ \t]*[=;]",

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.