Branch: refs/heads/master
Author: elextr <elextr(a)gmail.com>
Committer: Matthew Brush <mbrush(a)codebrainz.ca>
Date: Sat, 13 Jan 2018 05:03:22 UTC
Commit: 65097208df76439f0f059bafad5945624131475b
https://github.com/geany/geany/commit/65097208df76439f0f059bafad59456241314…
Log Message:
-----------
TravisCI: Remove requirement to fail build on aggregate return (#1740)
Returning large aggregates as values is a potential performance problem, but preventing all aggregate returns is inappropriate because:
1. returning small aggregates that are mostly handled as complete objects as return values often makes code clearer.
2. Modern (well not so modern actually) ABIs allow for small aggregates to be returned in registers, so forcing all returns to memory is actually likely to be slower.
3. if code review does not notice a large aggregate return and nobody notices a performance issue then it doesn't matter
Modified Paths:
--------------
.travis.yml
Modified: .travis.yml
2 lines changed, 1 insertions(+), 1 deletions(-)
===================================================================
@@ -21,7 +21,7 @@ install:
- sudo apt-get install -y --no-install-recommends doxygen
- sudo apt-get install -y python-lxml
before_script:
- - export CFLAGS="-g -O2 -Werror=pointer-arith -Werror=aggregate-return -Werror=implicit-function-declaration"
+ - export CFLAGS="-g -O2 -Werror=pointer-arith -Werror=implicit-function-declaration"
script:
- NOCONFIGURE=1 ./autogen.sh
- >
--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).
Branch: refs/heads/master
Author: Matthew Brush <matt(a)geany.org>
Committer: Matthew Brush <matt(a)geany.org>
Date: Thu, 21 Dec 2017 01:22:51 UTC
Commit: fce58626b1605981655090fcea06824f29aaa823
https://github.com/geany/geany/commit/fce58626b1605981655090fcea06824f29aaa…
Log Message:
-----------
Add 'fall through' comments and fix actual bug
To document when switch cases fall through intentionally, hiding the
warning by GCC at the same time.
Moved the break statement outside of the if conditional in keybindings.c
as I believe this was an actual bug found by GCC's warnings.
Modified Paths:
--------------
src/highlighting.c
src/keybindings.c
src/search.c
src/tools.c
Modified: src/highlighting.c
3 lines changed, 3 insertions(+), 0 deletions(-)
===================================================================
@@ -284,10 +284,13 @@ static void parse_keyfile_style(GKeyFile *kf, gchar **list,
{
case 4:
style->italic = utils_atob(list[3]);
+ /* fall through */
case 3:
style->bold = utils_atob(list[2]);
+ /* fall through */
case 2:
parse_color(kf, list[1], &style->background);
+ /* fall through */
case 1:
parse_color(kf, list[0], &style->foreground);
}
Modified: src/keybindings.c
2 lines changed, 1 insertions(+), 1 deletions(-)
===================================================================
@@ -2614,8 +2614,8 @@ static gboolean cb_func_document_action(guint key_id)
{
gint line = sci_get_current_line(doc->editor->sci);
editor_toggle_fold(doc->editor, line, 0);
- break;
}
+ break;
case GEANY_KEYS_DOCUMENT_REMOVE_MARKERS:
on_remove_markers1_activate(NULL, NULL);
break;
Modified: src/search.c
1 lines changed, 1 insertions(+), 0 deletions(-)
===================================================================
@@ -1879,6 +1879,7 @@ static void search_finished(GPid child_pid, gint status, gpointer user_data)
}
case 1:
msg = _("No matches found.");
+ /* fall through */
default:
msgwin_msg_add_string(COLOR_BLUE, -1, NULL, msg);
ui_set_statusbar(FALSE, "%s", msg);
Modified: src/tools.c
1 lines changed, 1 insertions(+), 0 deletions(-)
===================================================================
@@ -648,6 +648,7 @@ static void word_count(gchar *text, guint *chars, guint *lines, guint *words)
{
case '\n':
(*lines)++;
+ /* fall through */
case '\r':
case '\f':
case '\t':
--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).
Branch: refs/heads/master
Author: Matthew Brush <matt(a)geany.org>
Committer: Matthew Brush <matt(a)geany.org>
Date: Thu, 21 Dec 2017 01:22:51 UTC
Commit: 43122ea7d95808b04e44d03a4650de0d28d04d97
https://github.com/geany/geany/commit/43122ea7d95808b04e44d03a4650de0d28d04…
Log Message:
-----------
Add more 'fall through' comments for switch cases
TODO: make sure these are actually meant to fall-through.
Modified Paths:
--------------
ctags/parsers/perl.c
ctags/parsers/r.c
Modified: ctags/parsers/perl.c
2 lines changed, 2 insertions(+), 0 deletions(-)
===================================================================
@@ -138,9 +138,11 @@ static bool isSubroutineDeclaration (const unsigned char *cp)
case ';':
if (!nparens)
return true;
+ /* fall through */
case '{':
if (!nparens)
return false;
+ /* fall through */
default:
if (attr) {
if (isIdentifier1(*cp)) {
Modified: ctags/parsers/r.c
1 lines changed, 1 insertions(+), 0 deletions(-)
===================================================================
@@ -142,6 +142,7 @@ static void createRTags (void)
break;
}
}
+ /* fall through */
case ' ':
case '\x009':
/* skip whitespace */
--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).
Branch: refs/heads/master
Author: Matthew Brush <matt(a)geany.org>
Committer: Matthew Brush <matt(a)geany.org>
Date: Thu, 21 Dec 2017 01:22:51 UTC
Commit: bf28794635735d97ba60d458f964bdb46972f9e5
https://github.com/geany/geany/commit/bf28794635735d97ba60d458f964bdb46972f…
Log Message:
-----------
Adjust 'fall through' comments to be recognized by GCC
As per the documentation[0], GCC will silence these warnings when
the comments are formatted correctly.
[0]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
Modified Paths:
--------------
ctags/parsers/fortran.c
Modified: ctags/parsers/fortran.c
4 lines changed, 2 insertions(+), 2 deletions(-)
===================================================================
@@ -673,7 +673,7 @@ static int getFixedFormChar (void)
Column = 6;
break;
}
- /* fall through to next case */
+ /* fall through */
case LTYPE_CONTINUATION:
Column = 5;
do
@@ -1001,7 +1001,7 @@ static void readToken (tokenInfo *const token)
skipLine ();
Column = 0;
}
- /* fall through to newline case */
+ /* fall through */
case '\n':
token->type = TOKEN_STATEMENT_END;
if (FreeSourceForm)
--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).