Branch: refs/heads/master
Author: Jiří Techet <techet(a)gmail.com>
Committer: Jiří Techet <techet(a)gmail.com>
Date: Thu, 23 Jun 2016 16:53:49 UTC
Commit: 77590232cde2cc225e058a64ca98ff815ab4d633
https://github.com/geany/geany-osx/commit/77590232cde2cc225e058a64ca98ff815…
Log Message:
-----------
Update name of the most innovative operating system
Plus some minor updates.
Modified Paths:
--------------
README.md
Modified: README.md
28 lines changed, 14 insertions(+), 14 deletions(-)
===================================================================
@@ -1,12 +1,12 @@
-Geany OS X
-==========
-Geany OS X is a project that contains all the necessary configuration
+Geany for macOS
+===============
+Geany for macOS is a project that contains all the necessary configuration
files, themes, scripts and instructions to create the Geany app bundle and
-a dmg installer image for OS X.
+a dmg installer image for macOS.
Binaries
--------
-The OS X binaries can be downloaded from the Geany Releases page:
+The macOS binaries can be downloaded from the Geany Releases page:
<http://www.geany.org/Download/Releases>
@@ -21,20 +21,20 @@ A brief description of the contents of the project directory:
* *iconbuilder.iconset*: contains source icons for the Geany.icns
file. Not needed for normal build, present just in case the icns file
needs to be recreated for some reason.
-* *patches*: patches fixing VTE under OS X and enabling VTE bundling.
+* *patches*: patches fixing VTE under macOS and enabling VTE bundling.
### Configuration files
* *geany.modules*: JHBuild modules file with Geany dependencies.
* *geany.bundle*: configuration file describing the contents of the
app bundle.
-* *Info.plist*: OS X application configuration file containing some basic
+* *Info.plist*: macOS application configuration file containing some basic
information such as application name, version, etc. but also additional
configuration including file types the application can open.
* *gtkrc.theme, close.png*: GTK theme based on the Greybird theme and
- modified to match the OS X Yosemite theme better.
+ modified to match the macOS theme better.
* *gtkrc*: GTK configuration file including the theme file and changing
some Geany gtkrc settings.
-* *Geany.icns*: OS X Geany icon file.
+* *Geany.icns*: macOS Geany icon file.
### Scripts
* *launcher.sh*: launcher script from the gtk-mac-bundler project setting
@@ -49,7 +49,7 @@ A brief description of the contents of the project directory:
General Instructions
--------------------
-For more general instructions about building and bundling OS X applications
+For more general instructions about building and bundling macOS applications
please visit
<https://wiki.gnome.org/Projects/GTK%2B/OSX/>
@@ -59,8 +59,8 @@ building and bundling Geany.
Prerequisities
--------------
-* OS X 10.7 or later (tested with OS X 10.10)
-* Xcode and command-line tools (tested with Xcode 6.1.1)
+* OS X 10.7 or later
+* Xcode and command-line tools
JHBuild Installation
--------------------
@@ -97,7 +97,7 @@ To create the bundle, you need to first install JHBuild and GTK as described bel
Instead of meta-gtk-osx-core (GTK 2) you can also use `meta-gtk-osx-gtk3` to
install GTK 3. Note that both GTK 2 and GTK 3 cannot be installed at the
- same time. Also note that there seem to be various problems with the OS X
+ same time. Also note that there seem to be various problems with the macOS
support in GTK 3; for this reason I have not spent more time with the GTK 3
backend so there is no GTK3-specific theme or bundling support at this
moment.
@@ -220,4 +220,4 @@ have to be performed during normal bundle/installer creation:
---
-Jiri Techet, 2015
+Jiri Techet, 2016
--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).
Branch: refs/heads/master
Author: Jiří Techet <techet(a)gmail.com>
Committer: Jiří Techet <techet(a)gmail.com>
Date: Thu, 23 Jun 2016 16:10:50 UTC
Commit: 6a3a53f421a6868ca041352ac04c91e67886b458
https://github.com/geany/geany/commit/6a3a53f421a6868ca041352ac04c91e67886b…
Log Message:
-----------
Fix undo of line end type change
At the moment undo of line end type change only undos the changes made
in the document but the different line ending settings remains active.
This patch fixes the issue by combining the line end scintilla undo action
with a new UNDO_EOL action responsible for updating the line ending
settings.
Fixes #409
Modified Paths:
--------------
src/callbacks.c
src/document.c
src/documentprivate.h
Modified: src/callbacks.c
7 lines changed, 7 insertions(+), 0 deletions(-)
===================================================================
@@ -497,8 +497,15 @@ static void convert_eol(gint mode)
g_return_if_fail(doc != NULL);
+ /* sci_convert_eols() adds UNDO_SCINTILLA action in on_editor_notify().
+ * It is added to the undo stack before sci_convert_eols() finishes
+ * so after adding UNDO_EOL, UNDO_EOL will be at the top of the stack
+ * and UNDO_SCINTILLA below it. */
sci_convert_eols(doc->editor->sci, mode);
+ document_undo_add(doc, UNDO_EOL, GINT_TO_POINTER(sci_get_eol_mode(doc->editor->sci)));
+
sci_set_eol_mode(doc->editor->sci, mode);
+
ui_update_statusbar(doc, -1);
}
Modified: src/document.c
38 lines changed, 38 insertions(+), 0 deletions(-)
===================================================================
@@ -2953,6 +2953,25 @@ void document_undo(GeanyDocument *doc)
g_free(action->data);
break;
}
+ case UNDO_EOL:
+ {
+ undo_action *next_action;
+
+ document_redo_add(doc, UNDO_EOL, GINT_TO_POINTER(sci_get_eol_mode(doc->editor->sci)));
+
+ sci_set_eol_mode(doc->editor->sci, GPOINTER_TO_INT(action->data));
+
+ ui_update_statusbar(doc, -1);
+ ui_document_show_hide(doc);
+
+ /* When undoing, UNDO_EOL is always followed by UNDO_SCINTILLA
+ * which undos the line endings in the editor and should be
+ * performed together with UNDO_EOL. */
+ next_action = g_trash_stack_peek(&doc->priv->undo_actions);
+ if (next_action && next_action->type == UNDO_SCINTILLA)
+ document_undo(doc);
+ break;
+ }
case UNDO_RELOAD:
{
UndoReloadData *data = (UndoReloadData*)action->data;
@@ -3017,9 +3036,18 @@ void document_redo(GeanyDocument *doc)
{
case UNDO_SCINTILLA:
{
+ undo_action *next_action;
+
document_undo_add_internal(doc, UNDO_SCINTILLA, NULL);
sci_redo(doc->editor->sci);
+
+ /* When redoing an EOL change, the UNDO_SCINTILLA which changes
+ * the line ends in the editor is followed by UNDO_EOL
+ * which should be performed together with UNDO_SCINTILLA. */
+ next_action = g_trash_stack_peek(&doc->priv->redo_actions);
+ if (next_action != NULL && next_action->type == UNDO_EOL)
+ document_redo(doc);
break;
}
case UNDO_BOM:
@@ -3044,6 +3072,16 @@ void document_redo(GeanyDocument *doc)
g_free(action->data);
break;
}
+ case UNDO_EOL:
+ {
+ document_undo_add_internal(doc, UNDO_EOL, GINT_TO_POINTER(sci_get_eol_mode(doc->editor->sci)));
+
+ sci_set_eol_mode(doc->editor->sci, GPOINTER_TO_INT(action->data));
+
+ ui_update_statusbar(doc, -1);
+ ui_document_show_hide(doc);
+ break;
+ }
case UNDO_RELOAD:
{
UndoReloadData *data = (UndoReloadData*)action->data;
Modified: src/documentprivate.h
1 lines changed, 1 insertions(+), 0 deletions(-)
===================================================================
@@ -35,6 +35,7 @@ enum
UNDO_ENCODING,
UNDO_BOM,
UNDO_RELOAD,
+ UNDO_EOL,
UNDO_ACTIONS_MAX
};
--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).