Commits August 2014

commits@lists.geany.org

1 participants
94 discussions

[geany/geany] 768659: i18n: don't restrict LINGUAS at configure time
by Colomban Wendling 16 Aug '14

16 Aug '14

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Sat, 16 Aug 2014 15:59:10 UTC Commit: 768659b89fc8bc6727f5bce7605d417edc859f4a https://github.com/geany/geany/commit/768659b89fc8bc6727f5bce7605d417edc859… Log Message: ----------- i18n: don't restrict LINGUAS at configure time Don't use the $LINGUAS at configure time to set ALL_LINGUAS, and let the translations Makefile properly honor the $LINGUAS itself, which it already does better than we do, cleanly ignoring translations it doesn't know. If we do set ALL_LINGUAS=$LINGUAS, it will result in a build failure if we do not have a translation for some of the language(s) specified in $LINGUAS, and would make it impossible to build other languages without re-configuring. So, just drop that part and let the build-time support kick in. Closes #507. Modified Paths: -------------- m4/geany-i18n.m4 Modified: m4/geany-i18n.m4 6 lines changed, 1 insertions(+), 5 deletions(-) =================================================================== @@ -10,11 +10,7 @@ AC_DEFUN([GEANY_I18N], AC_SUBST([GETTEXT_PACKAGE]) AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE], ["$GETTEXT_PACKAGE"], [Gettext package.]) - if test -n "${LINGUAS}"; then - ALL_LINGUAS="${LINGUAS}" - else - ALL_LINGUAS=`cd "$srcdir/po" 2>/dev/null && ls *.po 2>/dev/null | $AWK 'BEGIN { FS="."; ORS=" " } { print $[]1 }'` - fi + ALL_LINGUAS=`cd "$srcdir/po" 2>/dev/null && ls *.po 2>/dev/null | $AWK 'BEGIN { FS="."; ORS=" " } { print $[]1 }'` AM_GLIB_GNU_GETTEXT # workaround for intltool bug (http://bugzilla.gnome.org/show_bug.cgi?id=490845) -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany] 91d0ed: Find in Files: start search when pressing return in all field
by Colomban Wendling 14 Aug '14

14 Aug '14

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Thu, 14 Aug 2014 15:12:58 UTC Commit: 91d0ed218341e6e0c7c9eb47f2f8fa8846b0a806 https://github.com/geany/geany/commit/91d0ed218341e6e0c7c9eb47f2f8fa8846b0a… Log Message: ----------- Find in Files: start search when pressing return in all field Patch partly from Yosef Or Boczko, thanks. Closes #959. Modified Paths: -------------- src/search.c Modified: src/search.c 2 lines changed, 2 insertions(+), 0 deletions(-) =================================================================== @@ -926,6 +926,7 @@ static void create_fif_dialog(void) dir_combo = gtk_combo_box_text_new_with_entry(); entry = gtk_bin_get_child(GTK_BIN(dir_combo)); ui_entry_add_clear_icon(GTK_ENTRY(entry)); + gtk_entry_set_activates_default(GTK_ENTRY(entry), TRUE); gtk_label_set_mnemonic_widget(GTK_LABEL(label1), entry); gtk_entry_set_width_chars(GTK_ENTRY(entry), 50); fif_dlg.dir_combo = dir_combo; @@ -1004,6 +1005,7 @@ static void create_fif_dialog(void) entry_extra = gtk_entry_new(); ui_entry_add_clear_icon(GTK_ENTRY(entry_extra)); + gtk_entry_set_activates_default(GTK_ENTRY(entry_extra), TRUE); gtk_widget_set_sensitive(entry_extra, FALSE); gtk_widget_set_tooltip_text(entry_extra, _("Other options to pass to Grep")); ui_hookup_widget(fif_dlg.dialog, entry_extra, "entry_extra"); -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany] 328c22: Update Scintilla to version 3.5.0
by Colomban Wendling 13 Aug '14

13 Aug '14

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Wed, 13 Aug 2014 12:07:03 UTC Commit: 328c22eaf6164b8e8cdc7e4ad4193d9122197903 https://github.com/geany/geany/commit/328c22eaf6164b8e8cdc7e4ad4193d9122197… Log Message: ----------- Update Scintilla to version 3.5.0 Modified Paths: -------------- scintilla/gtk/ScintillaGTK.cxx Modified: scintilla/gtk/ScintillaGTK.cxx 2 lines changed, 1 insertions(+), 1 deletions(-) =================================================================== @@ -2402,7 +2402,7 @@ void ScintillaGTK::PreeditChangedThis() { PreEditString utfval(im_context); - if (strlen(utfval.str) > maxLenInputIME * 3) { + if ((strlen(utfval.str) == 0) || strlen(utfval.str) > maxLenInputIME * 3) { return; // Do not allow over 200 chars. } -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany] 521778: Color scheme dialog: scroll to the initially selected item
by Colomban Wendling 12 Aug '14

12 Aug '14

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Tue, 12 Aug 2014 18:40:21 UTC Commit: 521778ad311d076d1d423c4d9e4421fd66c57bf3 https://github.com/geany/geany/commit/521778ad311d076d1d423c4d9e4421fd66c57… Log Message: ----------- Color scheme dialog: scroll to the initially selected item Modified Paths: -------------- src/highlighting.c Modified: src/highlighting.c 4 lines changed, 4 insertions(+), 0 deletions(-) =================================================================== @@ -1329,6 +1329,7 @@ void highlighting_show_color_scheme_dialog(void) GtkTreeViewColumn *column; GtkTreeSelection *treesel; GtkTreeIter current_iter; + GtkTreePath *path; GtkWidget *vbox, *swin, *tree; GeanyDocument *doc; @@ -1353,6 +1354,9 @@ void highlighting_show_color_scheme_dialog(void) treesel = gtk_tree_view_get_selection(GTK_TREE_VIEW(tree)); gtk_tree_selection_select_iter(treesel, &current_iter); + path = gtk_tree_model_get_path(GTK_TREE_MODEL(store), &current_iter); + gtk_tree_view_scroll_to_cell(GTK_TREE_VIEW(tree), path, NULL, FALSE, 0, 0); + gtk_tree_path_free(path); g_signal_connect(treesel, "changed", G_CALLBACK(on_color_scheme_changed), NULL); /* old dialog may still be showing */ -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany] df9643: Remove a global in colorscheme dialog code
by Colomban Wendling 12 Aug '14

12 Aug '14

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Tue, 12 Aug 2014 18:38:59 UTC Commit: df964312b2b2e27b28d127aa30e814d5d367a0c3 https://github.com/geany/geany/commit/df964312b2b2e27b28d127aa30e814d5d367a… Log Message: ----------- Remove a global in colorscheme dialog code Modified Paths: -------------- src/highlighting.c Modified: src/highlighting.c 29 lines changed, 12 insertions(+), 17 deletions(-) =================================================================== @@ -1184,8 +1184,6 @@ const GeanyLexerStyle *highlighting_get_style(gint ft_id, gint style_id) } -static GtkWidget *scheme_tree = NULL; - enum { SCHEME_MARKUP, @@ -1247,7 +1245,7 @@ static gchar *utils_get_setting_locale_string(GKeyFile *keyfile, static void add_color_scheme_item(GtkListStore *store, - gchar *name, gchar *desc, const gchar *fn) + gchar *name, gchar *desc, const gchar *fn, GtkTreeIter *current_iter) { GtkTreeIter iter; gchar *markup; @@ -1264,17 +1262,12 @@ static void add_color_scheme_item(GtkListStore *store, SCHEME_FILE, fn, -1); g_free(markup); - if (utils_str_equal(fn, editor_prefs.color_scheme)) - { - GtkTreeSelection *treesel = - gtk_tree_view_get_selection(GTK_TREE_VIEW(scheme_tree)); - - gtk_tree_selection_select_iter(treesel, &iter); - } + if (utils_str_equal(fn, editor_prefs.color_scheme) && current_iter) + *current_iter = iter; } -static void add_color_scheme_file(GtkListStore *store, const gchar *fname) +static void add_color_scheme_file(GtkListStore *store, const gchar *fname, GtkTreeIter *current_iter) { GKeyFile *hkeyfile, *skeyfile; gchar *path, *theme_name, *theme_desc; @@ -1287,7 +1280,7 @@ static void add_color_scheme_file(GtkListStore *store, const gchar *fname) theme_name = utils_get_setting(locale_string, hkeyfile, skeyfile, "theme_info", "name", theme_fn); theme_desc = utils_get_setting(locale_string, hkeyfile, skeyfile, "theme_info", "description", NULL); - add_color_scheme_item(store, theme_name, theme_desc, theme_fn); + add_color_scheme_item(store, theme_name, theme_desc, theme_fn, current_iter); g_free(path); g_free(theme_fn); @@ -1298,11 +1291,11 @@ static void add_color_scheme_file(GtkListStore *store, const gchar *fname) } -static gboolean add_color_scheme_items(GtkListStore *store) +static gboolean add_color_scheme_items(GtkListStore *store, GtkTreeIter *current_iter) { GSList *list, *node; - add_color_scheme_item(store, _("Default"), _("Default"), NULL); + add_color_scheme_item(store, _("Default"), _("Default"), NULL, current_iter); list = utils_get_config_files(GEANY_COLORSCHEMES_SUBDIR); foreach_slist(node, list) @@ -1310,7 +1303,7 @@ static gboolean add_color_scheme_items(GtkListStore *store) gchar *fname = node->data; if (g_str_has_suffix(fname, ".conf")) - add_color_scheme_file(store, fname); + add_color_scheme_file(store, fname, current_iter); g_free(fname); } @@ -1335,6 +1328,7 @@ void highlighting_show_color_scheme_dialog(void) GtkCellRenderer *text_renderer; GtkTreeViewColumn *column; GtkTreeSelection *treesel; + GtkTreeIter current_iter; GtkWidget *vbox, *swin, *tree; GeanyDocument *doc; @@ -1344,7 +1338,7 @@ void highlighting_show_color_scheme_dialog(void) _("The current filetype overrides the default style."), _("This may cause color schemes to display incorrectly.")); - scheme_tree = tree = gtk_tree_view_new_with_model(GTK_TREE_MODEL(store)); + tree = gtk_tree_view_new_with_model(GTK_TREE_MODEL(store)); g_object_unref(store); gtk_tree_view_set_rules_hint(GTK_TREE_VIEW(tree), TRUE); gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(tree), FALSE); @@ -1355,9 +1349,10 @@ void highlighting_show_color_scheme_dialog(void) NULL, text_renderer, "markup", SCHEME_MARKUP, NULL); gtk_tree_view_append_column(GTK_TREE_VIEW(tree), column); - add_color_scheme_items(store); + add_color_scheme_items(store, &current_iter); treesel = gtk_tree_view_get_selection(GTK_TREE_VIEW(tree)); + gtk_tree_selection_select_iter(treesel, &current_iter); g_signal_connect(treesel, "changed", G_CALLBACK(on_color_scheme_changed), NULL); /* old dialog may still be showing */ -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany] 8b0990: Fix relative project base path when creating a new project
by Colomban Wendling 12 Aug '14

12 Aug '14

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Tue, 12 Aug 2014 14:42:50 UTC Commit: 8b0990e52a1c2bfaf8678d4e14fb18a256618ddb https://github.com/geany/geany/commit/8b0990e52a1c2bfaf8678d4e14fb18a256618… Log Message: ----------- Fix relative project base path when creating a new project Closes #1062. Modified Paths: -------------- src/project.c Modified: src/project.c 2 lines changed, 1 insertions(+), 1 deletions(-) =================================================================== @@ -680,7 +680,7 @@ static gboolean update_config(const PropertyDialogElements *e, gboolean new_proj if (! g_path_is_absolute(locale_path)) { /* relative base path, so add base dir of project file name */ gchar *dir = g_path_get_dirname(locale_filename); - SETPTR(locale_path, g_strconcat(dir, locale_path, NULL)); + SETPTR(locale_path, g_build_filename(dir, locale_path, NULL)); g_free(dir); } -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany] cc1c36: project: Sanitize entries_modified scope
by Colomban Wendling 12 Aug '14

12 Aug '14

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Tue, 12 Aug 2014 14:42:46 UTC Commit: cc1c36d0093de8c2559dfeb65eb60cc957489239 https://github.com/geany/geany/commit/cc1c36d0093de8c2559dfeb65eb60cc957489… Log Message: ----------- project: Sanitize entries_modified scope Modified Paths: -------------- src/project.c Modified: src/project.c 13 lines changed, 5 insertions(+), 8 deletions(-) =================================================================== @@ -64,8 +64,6 @@ static struct gchar *project_file_path; /* in UTF-8 */ } local_prefs = { NULL }; -static gboolean entries_modified; - /* simple struct to keep references to the elements of the properties dialog */ typedef struct _PropertyDialogElements { @@ -78,6 +76,7 @@ typedef struct _PropertyDialogElements GtkWidget *patterns; BuildTableData build_properties; gint build_page_num; + gboolean entries_modified; } PropertyDialogElements; @@ -112,7 +111,7 @@ void project_new(void) GtkWidget *bbox; GtkWidget *label; gchar *tooltip; - PropertyDialogElements e = { NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0 }; + PropertyDialogElements e = { NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0, FALSE }; if (! project_ask_close()) return; @@ -131,8 +130,6 @@ void project_new(void) vbox = ui_dialog_vbox_new(GTK_DIALOG(e.dialog)); - entries_modified = FALSE; - table = gtk_table_new(3, 2, FALSE); gtk_table_set_row_spacings(GTK_TABLE(table), 5); gtk_table_set_col_spacings(GTK_TABLE(table), 10); @@ -903,7 +900,7 @@ static void on_name_entry_changed(GtkEditable *editable, PropertyDialogElements gchar *name; const gchar *project_dir = local_prefs.project_file_path; - if (entries_modified) + if (e->entries_modified) return; name = gtk_editable_get_chars(editable, 0, -1); @@ -928,7 +925,7 @@ static void on_name_entry_changed(GtkEditable *editable, PropertyDialogElements gtk_entry_set_text(GTK_ENTRY(e->base_path), base_path); gtk_entry_set_text(GTK_ENTRY(e->file_name), file_name); - entries_modified = FALSE; + e->entries_modified = FALSE; g_free(base_path); g_free(file_name); @@ -937,7 +934,7 @@ static void on_name_entry_changed(GtkEditable *editable, PropertyDialogElements static void on_entries_changed(GtkEditable *editable, PropertyDialogElements *e) { - entries_modified = TRUE; + e->entries_modified = TRUE; } -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany] 87c6ce: Remove dead assignment
by Colomban Wendling 12 Aug '14

12 Aug '14

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Tue, 12 Aug 2014 14:17:39 UTC Commit: 87c6cefc1940a8d8e4e02f842bdbfc4bf05e3e37 https://github.com/geany/geany/commit/87c6cefc1940a8d8e4e02f842bdbfc4bf05e3… Log Message: ----------- Remove dead assignment `entries_modified` global is only used by on_name_entry_changed() and on_entries_changed(), both of which are only ever called from project_new() scope -- which already initializes this variable. Modified Paths: -------------- src/project.c Modified: src/project.c 2 lines changed, 0 insertions(+), 2 deletions(-) =================================================================== @@ -509,8 +509,6 @@ static void show_project_properties(gboolean show_build) g_return_if_fail(app->project != NULL); - entries_modified = FALSE; - if (e.dialog == NULL) create_properties_dialog(&e); -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany] 0b2b64: Remove an unnecessary dynamic allocation
by Colomban Wendling 12 Aug '14

12 Aug '14

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Tue, 12 Aug 2014 12:39:53 UTC Commit: 0b2b647a6dfd76dd2e8ff4ff0b8e0eea84bad3c8 https://github.com/geany/geany/commit/0b2b647a6dfd76dd2e8ff4ff0b8e0eea84bad… Log Message: ----------- Remove an unnecessary dynamic allocation Modified Paths: -------------- src/project.c Modified: src/project.c 66 lines changed, 32 insertions(+), 34 deletions(-) =================================================================== @@ -112,25 +112,24 @@ void project_new(void) GtkWidget *bbox; GtkWidget *label; gchar *tooltip; - PropertyDialogElements *e; + PropertyDialogElements e = { NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 0 }; if (! project_ask_close()) return; g_return_if_fail(app->project == NULL); - e = g_new0(PropertyDialogElements, 1); - e->dialog = gtk_dialog_new_with_buttons(_("New Project"), GTK_WINDOW(main_widgets.window), + e.dialog = gtk_dialog_new_with_buttons(_("New Project"), GTK_WINDOW(main_widgets.window), GTK_DIALOG_DESTROY_WITH_PARENT, GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL, NULL); - gtk_widget_set_name(e->dialog, "GeanyDialogProject"); + gtk_widget_set_name(e.dialog, "GeanyDialogProject"); button = ui_button_new_with_image(GTK_STOCK_NEW, _("C_reate")); gtk_widget_set_can_default(button, TRUE); - gtk_window_set_default(GTK_WINDOW(e->dialog), button); - gtk_dialog_add_action_widget(GTK_DIALOG(e->dialog), button, GTK_RESPONSE_OK); + gtk_window_set_default(GTK_WINDOW(e.dialog), button); + gtk_dialog_add_action_widget(GTK_DIALOG(e.dialog), button, GTK_RESPONSE_OK); - vbox = ui_dialog_vbox_new(GTK_DIALOG(e->dialog)); + vbox = ui_dialog_vbox_new(GTK_DIALOG(e.dialog)); entries_modified = FALSE; @@ -141,32 +140,32 @@ void project_new(void) label = gtk_label_new(_("Name:")); gtk_misc_set_alignment(GTK_MISC(label), 1, 0); - e->name = gtk_entry_new(); - gtk_entry_set_activates_default(GTK_ENTRY(e->name), TRUE); - ui_entry_add_clear_icon(GTK_ENTRY(e->name)); - gtk_entry_set_max_length(GTK_ENTRY(e->name), MAX_NAME_LEN); - gtk_widget_set_tooltip_text(e->name, _("Project name")); + e.name = gtk_entry_new(); + gtk_entry_set_activates_default(GTK_ENTRY(e.name), TRUE); + ui_entry_add_clear_icon(GTK_ENTRY(e.name)); + gtk_entry_set_max_length(GTK_ENTRY(e.name), MAX_NAME_LEN); + gtk_widget_set_tooltip_text(e.name, _("Project name")); - ui_table_add_row(GTK_TABLE(table), 0, label, e->name, NULL); + ui_table_add_row(GTK_TABLE(table), 0, label, e.name, NULL); label = gtk_label_new(_("Filename:")); gtk_misc_set_alignment(GTK_MISC(label), 1, 0); - e->file_name = gtk_entry_new(); - gtk_entry_set_activates_default(GTK_ENTRY(e->file_name), TRUE); - ui_entry_add_clear_icon(GTK_ENTRY(e->file_name)); - gtk_entry_set_width_chars(GTK_ENTRY(e->file_name), 30); + e.file_name = gtk_entry_new(); + gtk_entry_set_activates_default(GTK_ENTRY(e.file_name), TRUE); + ui_entry_add_clear_icon(GTK_ENTRY(e.file_name)); + gtk_entry_set_width_chars(GTK_ENTRY(e.file_name), 30); tooltip = g_strdup_printf( _("Path of the file representing the project and storing its settings. " "It should normally have the \"%s\" extension."), "."GEANY_PROJECT_EXT); - gtk_widget_set_tooltip_text(e->file_name, tooltip); + gtk_widget_set_tooltip_text(e.file_name, tooltip); g_free(tooltip); button = gtk_button_new(); - g_signal_connect(button, "clicked", G_CALLBACK(on_file_save_button_clicked), e); + g_signal_connect(button, "clicked", G_CALLBACK(on_file_save_button_clicked), &e); image = gtk_image_new_from_stock(GTK_STOCK_OPEN, GTK_ICON_SIZE_BUTTON); gtk_container_add(GTK_CONTAINER(button), image); bbox = gtk_hbox_new(FALSE, 6); - gtk_box_pack_start(GTK_BOX(bbox), e->file_name, TRUE, TRUE, 0); + gtk_box_pack_start(GTK_BOX(bbox), e.file_name, TRUE, TRUE, 0); gtk_box_pack_start(GTK_BOX(bbox), button, FALSE, FALSE, 0); ui_table_add_row(GTK_TABLE(table), 1, label, bbox, NULL); @@ -174,33 +173,33 @@ void project_new(void) label = gtk_label_new(_("Base path:")); gtk_misc_set_alignment(GTK_MISC(label), 1, 0); - e->base_path = gtk_entry_new(); - gtk_entry_set_activates_default(GTK_ENTRY(e->base_path), TRUE); - ui_entry_add_clear_icon(GTK_ENTRY(e->base_path)); - gtk_widget_set_tooltip_text(e->base_path, + e.base_path = gtk_entry_new(); + gtk_entry_set_activates_default(GTK_ENTRY(e.base_path), TRUE); + ui_entry_add_clear_icon(GTK_ENTRY(e.base_path)); + gtk_widget_set_tooltip_text(e.base_path, _("Base directory of all files that make up the project. " "This can be a new path, or an existing directory tree. " "You can use paths relative to the project filename.")); bbox = ui_path_box_new(_("Choose Project Base Path"), - GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER, GTK_ENTRY(e->base_path)); + GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER, GTK_ENTRY(e.base_path)); ui_table_add_row(GTK_TABLE(table), 2, label, bbox, NULL); gtk_box_pack_start(GTK_BOX(vbox), table, TRUE, TRUE, 0); /* signals */ - g_signal_connect(e->name, "changed", G_CALLBACK(on_name_entry_changed), e); + g_signal_connect(e.name, "changed", G_CALLBACK(on_name_entry_changed), &e); /* run the callback manually to initialise the base_path and file_name fields */ - on_name_entry_changed(GTK_EDITABLE(e->name), e); + on_name_entry_changed(GTK_EDITABLE(e.name), &e); - g_signal_connect(e->file_name, "changed", G_CALLBACK(on_entries_changed), e); - g_signal_connect(e->base_path, "changed", G_CALLBACK(on_entries_changed), e); + g_signal_connect(e.file_name, "changed", G_CALLBACK(on_entries_changed), &e); + g_signal_connect(e.base_path, "changed", G_CALLBACK(on_entries_changed), &e); - gtk_widget_show_all(e->dialog); + gtk_widget_show_all(e.dialog); - while (gtk_dialog_run(GTK_DIALOG(e->dialog)) == GTK_RESPONSE_OK) + while (gtk_dialog_run(GTK_DIALOG(e.dialog)) == GTK_RESPONSE_OK) { - if (update_config(e, TRUE)) + if (update_config(&e, TRUE)) { if (!write_config(TRUE)) SHOW_ERR(_("Project file could not be written")); @@ -213,8 +212,7 @@ void project_new(void) } } } - gtk_widget_destroy(e->dialog); - g_free(e); + gtk_widget_destroy(e.dialog); } -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

[geany/geany] 6ed6a9: about: Don't leak global variables to the program scope
by Colomban Wendling 12 Aug '14

12 Aug '14

Branch: refs/heads/master Author: Colomban Wendling <ban(a)herbesfolles.org> Committer: Colomban Wendling <ban(a)herbesfolles.org> Date: Tue, 12 Aug 2014 12:38:48 UTC Commit: 6ed6a995651dc8e239df3ba23dda2f3df3aa23ac https://github.com/geany/geany/commit/6ed6a995651dc8e239df3ba23dda2f3df3aa2… Log Message: ----------- about: Don't leak global variables to the program scope Modified Paths: -------------- src/about.c Modified: src/about.c 4 lines changed, 2 insertions(+), 2 deletions(-) =================================================================== @@ -47,7 +47,7 @@ #define BUILDDATE "<span size=\"smaller\">%s</span>" #define COPYRIGHT _("Copyright (c) 2005-2014\nColomban Wendling\nNick Treleaven\nMatthew Brush\nEnrico Tröger\nFrank Lanitz\nAll rights reserved.") -const gchar *translators[][2] = { +static const gchar *translators[][2] = { { "ar", "Fayssal Chamekh <chamfay(a)gmail.com>"}, { "ast", "Marcos Costales <marcoscostales(a)gmail.com>"}, { "be_BY", "Yura Siamashka <yurand2(a)gmail.com>" }, @@ -92,7 +92,7 @@ const gchar *translators[][2] = { }; static const guint translators_len = G_N_ELEMENTS(translators); -const gchar *prev_translators[][2] = { +static const gchar *prev_translators[][2] = { { "es", "Damián Viano <debian(a)damianv.com.ar>\nNacho Cabanes <ncabanes(a)gmail.com>" }, { "pl", "Jacek Wolszczak <shutdownrunner(a)o2.xn--pl>\njarosaw-ctc Foksa <jfoksa(a)gmail.com>" }, { "nl", "Kurt De Bree <kdebree(a)telenet.be>" } -------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).

1 0

← Newer
1
2
3
4
5
6
7
8
9
10
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

Commits August 2014