Revision: 5884
http://geany.svn.sourceforge.net/geany/?rev=5884&view=rev
Author: colombanw
Date: 2011-08-06 18:33:04 +0000 (Sat, 06 Aug 2011)
Log Message:
-----------
Fix unlikely but theoretically possible use of an uninitialized variable
Modified Paths:
--------------
trunk/src/printing.c
Modified: trunk/src/printing.c
===================================================================
--- trunk/src/printing.c 2011-08-03 15:20:43 UTC (rev 5883)
+++ trunk/src/printing.c 2011-08-06 18:33:04 UTC (rev 5884)
@@ -511,7 +511,7 @@
GeanyEditor *editor;
cairo_t *cr;
gdouble width, height;
- gdouble x, y;
+ gdouble x = 0.0, y = 0.0;
/*gint layout_h;*/
gint count;
GString *str;
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Revision: 5883
http://geany.svn.sourceforge.net/geany/?rev=5883&view=rev
Author: colombanw
Date: 2011-08-03 15:20:43 +0000 (Wed, 03 Aug 2011)
Log Message:
-----------
Properly include string.h in stash.c since we use strcmp() (oops)
Modified Paths:
--------------
trunk/src/stash.c
Modified: trunk/src/stash.c
===================================================================
--- trunk/src/stash.c 2011-08-03 15:20:26 UTC (rev 5882)
+++ trunk/src/stash.c 2011-08-03 15:20:43 UTC (rev 5883)
@@ -85,6 +85,7 @@
#include "geany.h" /* necessary for utils.h, otherwise use gtk/gtk.h */
#include <stdlib.h> /* only for atoi() */
+#include <string.h> /* only for strcmp() */
#include "support.h" /* only for _("text") */
#include "utils.h" /* only for foreach_*, utils_get_setting_*(). Stash should not depend on Geany. */
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Revision: 5882
http://geany.svn.sourceforge.net/geany/?rev=5882&view=rev
Author: colombanw
Date: 2011-08-03 15:20:26 +0000 (Wed, 03 Aug 2011)
Log Message:
-----------
Only include config.h when building Geany
config.h is not distributed, and we includ it from geany.h. Even
though it was only included it HAVE_CONFIG_H was defined, an Autotools
based build system is likely to define it, and it becomes a problem if
that very build system uses another header name than config.h.
Closes #3384026
Modified Paths:
--------------
trunk/ChangeLog
trunk/plugins/classbuilder.c
trunk/plugins/export.c
trunk/plugins/filebrowser.c
trunk/plugins/htmlchars.c
trunk/plugins/saveactions.c
trunk/plugins/splitwindow.c
trunk/src/geany.h
Modified: trunk/ChangeLog
===================================================================
--- trunk/ChangeLog 2011-08-01 19:31:56 UTC (rev 5881)
+++ trunk/ChangeLog 2011-08-03 15:20:26 UTC (rev 5882)
@@ -1,3 +1,11 @@
+2011-08-03 Colomban Wendling <colomban(at)geany(dot)org>
+
+ * src/geany.h, plugins/classbuilder.c, plugins/export.c,
+ plugins/filebrowser.c, plugins/htmlchars.c, plugins/saveactions.c,
+ plugins/splitwindow.c:
+ Only include config.h when building Geany (closes #3384026).
+
+
2011-07-31 Frank Lanitz <frlan(a)frank.uvena.de>
* doc/plugins.dox:
@@ -5,7 +13,6 @@
HowTo as well as a hint to make usage of main_locale_init().
-
2011-07-28 Colomban Wendling <colomban(at)geany(dot)org>
* src/build.c, src/build.h, src/editor.c, src/interface.c,
Modified: trunk/plugins/classbuilder.c
===================================================================
--- trunk/plugins/classbuilder.c 2011-08-01 19:31:56 UTC (rev 5881)
+++ trunk/plugins/classbuilder.c 2011-08-03 15:20:26 UTC (rev 5882)
@@ -25,6 +25,10 @@
/* Class Builder - creates source files containing a new class interface and definition. */
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include "geanyplugin.h"
GeanyData *geany_data;
Modified: trunk/plugins/export.c
===================================================================
--- trunk/plugins/export.c 2011-08-01 19:31:56 UTC (rev 5881)
+++ trunk/plugins/export.c 2011-08-03 15:20:26 UTC (rev 5882)
@@ -24,6 +24,10 @@
/* Export plugin. */
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include <ctype.h>
#include <math.h>
Modified: trunk/plugins/filebrowser.c
===================================================================
--- trunk/plugins/filebrowser.c 2011-08-01 19:31:56 UTC (rev 5881)
+++ trunk/plugins/filebrowser.c 2011-08-03 15:20:26 UTC (rev 5882)
@@ -24,6 +24,10 @@
/* Sidebar file browser plugin. */
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include "geanyplugin.h"
#include <string.h>
Modified: trunk/plugins/htmlchars.c
===================================================================
--- trunk/plugins/htmlchars.c 2011-08-01 19:31:56 UTC (rev 5881)
+++ trunk/plugins/htmlchars.c 2011-08-03 15:20:26 UTC (rev 5882)
@@ -25,6 +25,10 @@
/* HTML Characters plugin (Inserts HTML character entities like '&') */
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include "geanyplugin.h"
#include <string.h>
#include "SciLexer.h"
Modified: trunk/plugins/saveactions.c
===================================================================
--- trunk/plugins/saveactions.c 2011-08-01 19:31:56 UTC (rev 5881)
+++ trunk/plugins/saveactions.c 2011-08-03 15:20:26 UTC (rev 5882)
@@ -23,6 +23,10 @@
*/
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include "geanyplugin.h"
#include <unistd.h>
Modified: trunk/plugins/splitwindow.c
===================================================================
--- trunk/plugins/splitwindow.c 2011-08-01 19:31:56 UTC (rev 5881)
+++ trunk/plugins/splitwindow.c 2011-08-03 15:20:26 UTC (rev 5882)
@@ -24,6 +24,10 @@
/* Split Window plugin. */
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include "geanyplugin.h"
#include <string.h>
Modified: trunk/src/geany.h
===================================================================
--- trunk/src/geany.h 2011-08-01 19:31:56 UTC (rev 5881)
+++ trunk/src/geany.h 2011-08-03 15:20:26 UTC (rev 5882)
@@ -27,8 +27,8 @@
#ifndef GEANY_H
#define GEANY_H
-#ifdef HAVE_CONFIG_H
-# include <config.h>
+#if defined(HAVE_CONFIG_H) && defined(GEANY_PRIVATE)
+# include "config.h"
#endif
#include <gtk/gtk.h>
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Revision: 5881
http://geany.svn.sourceforge.net/geany/?rev=5881&view=rev
Author: frlan
Date: 2011-08-01 19:31:56 +0000 (Mon, 01 Aug 2011)
Log Message:
-----------
Adding a hint to prevent double usage of main_local_init() also to function documentation and correct word order.
Modified Paths:
--------------
trunk/doc/plugins.dox
trunk/src/main.c
Modified: trunk/doc/plugins.dox
===================================================================
--- trunk/doc/plugins.dox 2011-08-01 19:20:39 UTC (rev 5880)
+++ trunk/doc/plugins.dox 2011-08-01 19:31:56 UTC (rev 5881)
@@ -453,5 +453,5 @@
* @endcode
*
* If you already did use PLUGIN_SET_TRANSLATABLE_INFO() you don't need
- * to add main_locale_init() as it has been already called.
+ * to add main_locale_init() as it has already been called.
**/
Modified: trunk/src/main.c
===================================================================
--- trunk/src/main.c 2011-08-01 19:20:39 UTC (rev 5880)
+++ trunk/src/main.c 2011-08-01 19:31:56 UTC (rev 5881)
@@ -425,6 +425,9 @@
* to adjust the build system of your plugin to get internationalisation support
* working properly.
*
+ * If you have already used @ref PLUGIN_SET_TRANSLATABLE_INFO() you
+ * don't need to call main_locale_init() again as it has already been done.
+ *
* @param locale_dir The location where the translation files should be searched. This is
* usually the @c LOCALEDIR macro, defined by the build system.
* E.g. @c $prefix/share/locale.
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Revision: 5880
http://geany.svn.sourceforge.net/geany/?rev=5880&view=rev
Author: frlan
Date: 2011-08-01 19:20:39 +0000 (Mon, 01 Aug 2011)
Log Message:
-----------
Add hint to prevent double calling of main_local_init() into plugin HowTo.
Modified Paths:
--------------
trunk/doc/plugins.dox
Modified: trunk/doc/plugins.dox
===================================================================
--- trunk/doc/plugins.dox 2011-07-31 17:37:12 UTC (rev 5879)
+++ trunk/doc/plugins.dox 2011-08-01 19:20:39 UTC (rev 5880)
@@ -451,4 +451,7 @@
G_CALLBACK(item_activate_cb), NULL);
}
* @endcode
+ *
+ * If you already did use PLUGIN_SET_TRANSLATABLE_INFO() you don't need
+ * to add main_locale_init() as it has been already called.
**/
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.