[Github-comments] [geany/geany] Enable local variables for C/C++ and improve autocompletion (PR #3185)

[Jiří Techet]

@techee commented on this pull request.



>  	foreach_ptr_array(tmtag, i, tags)
 	{
+		if (!tm_workspace_is_autocomplete_tag(tmtag, doc->tm_file, current_line, current_scope))

This is because for tag definition/declaration goto basically the same conditions like for autocompletion apply. Without this patch, if you perform the goto for e.g. variable `i`, you'd see all the local variables `i`'s in your project, which is a lot and irrelevant to the current function.

Maybe `tm_workspace_is_autocomplete_tag()` could be named a different way, I just couldn't come up with a better name.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3185#discussion_r867918618
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3185/review/965992594 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220509/bbe310af/attachment.htm>