[Github-comments] [geany/geany] Enable local variables for C/C++ and improve autocompletion (PR #3185)

Jiří Techet notifications at github.com
Mon May 9 12:04:18 UTC 2022


To be clear, no hard feelings here, I just want to progress with this PR so everybody is happy. I'm pretty flexible with how to proceed, some extra work is fine with me, but I don't want to do the ping pong that guy A says "do it this way", I do it, and guy B says "don't do it that way".

Similarly with the header patch - if I open a separate PR for it, I'd like to prepare it in such a way that it's acceptable for everyone so that I don't have to rework it again. My current proposal is to have a hash table in `TMWorkspace` mapping `short_name` (filename without path) to the corresponding `TMSourceFile`, enable include tag generation and sort the tags that those from the included files are before the rest of the workspace tags (with highest priority given to the header having the same name as the current file). This avoids the hard-coded file extensions and the lookup should be fast thanks to the hash table. Does this proposal sound as a good way to implement it?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3185#issuecomment-1121011137
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3185/c1121011137 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220509/82c319a4/attachment.htm>


More information about the Github-comments mailing list