[Github-comments] [geany/geany] Enable local variables for C/C++ and improve autocompletion (PR #3185)

[Thomas Martitz]

I'm not fundamentally opposed to the header patch (and I never that something like that). But I have concerns about the exact requirements and implementation that are better dealt with in a separate PR, IMO. It became clear to me that it adds a lot of benefit and @elextr totally wants to have it so I want to make sure the implementation is solid when we merge it.

I truly don't understand why it causes so much friction when I ask to separate out an unrelated feature. I really only want to focus on "completing local variable" for this PR so we can get it in ASAP (I already failed at that goal because it probably would be merged already if I just kept shut up) and then improve user experience through other means separately. If you think that I would want to reject one PR or another then that's really not the case. But given my limited time to actually review code changes I really want to focus on individual PRs (ideally with reasonably small diffs) because I can't accept overloaded PRs with confidence.

Also I did mean it honest when I said that @elextr and you can deal with this PR without my involvement. I'm OK as long as there is one other person that can assess the changes. Ultimately, I'm even OK with merging PRs without review if it's really impossible to get any feedback (not uncommon these days, unfortunately) though it come with a kind of warning in advance.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3185#issuecomment-1120470151
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/3185/c1120470151 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220508/ff077681/attachment.htm>