[Github-comments] [geany/geany] Crash after update to Scintilla 5.1.5 (Issue #3095)

[Thomas Martitz]

I found the problem, will open a PR in a few minutes. The problem is the explicit NUL termination that I added to `sci_get_text()` which is superfluous anyway (so the fix removes it). But my change to `sci_get_contents()` is flawed as well.

My opinion regarding the scintilla change itself and how we proceed:
1) I think the change makes generally sense and I appreciate making APIs similar to each other so. It's unfortunate that it's a breaking change but it was communicated well enough, at least I was aware and tried to make the necessary changes (and failed ;-) I wouldn't necessary say it's something that deserves a major version increment, I don't even know if the Scintilla project uses version numbers like that.

2) Assuming Neil leaves the change as is, I think we should just get along and make the fixes in g-p.
On our side we should definitely increment the plugin API so that plugins can adapt to the behavior (or reject running on older Geany).
Incrementing the ABI, on the other hand, does not make sense. It cannot fix the plugin code. All it does is giving the false idea that recompiling the affected plugin resolves the situation.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3095#issuecomment-1010378991
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/issues/3095/1010378991 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220111/0a5f4fb6/attachment.htm>