[Github-comments] [geany/geany] Crash after update to Scintilla 5.1.5 (Issue #3095)

[Jiří Techet]

> I found the problem, will open a PR in a few minutes. The problem is the explicit NUL termination that I added to sci_get_text() which is superfluous anyway (so the fix removes it).

Yep.

> I think the change makes generally sense and I appreciate making APIs similar to each other so. It's unfortunate that it's a breaking change but it was communicated well enough, at least I was aware and tried to make the necessary changes (and failed ;-) I wouldn't necessary say it's something that deserves a major version increment, I don't even know if the Scintilla project uses version numbers like that.

To me this change isn't a good idea. Scintilla has been very stable API-wise. When you consider that we migrated from Scintilla 3 to Scintilla 5 which is something like a 4 year difference without any change like that needed and then there comes Scintilla 5.1.5 after Scintilla 5.1.4 one month apart that requires that all editors and their plugins have to be updated, it's quite a difference and IMO a major underestimate of what this change would cause. I think someone who updates Scintilla once a year will just miss this change. This isn't just Geany but all the other editors that use Scintilla and this is the kind of API change I'd expect from a 0.x release where API isn't stable but not from a component that has been here for years. Yes, the API isn't consistent but this is just part of historical heritage.

> Assuming Neil leaves the change as is, I think we should just get along and make the fixes in g-p.
On our side we should definitely increment the plugin API so that plugins can adapt to the behavior (or reject running on older Geany).

Of course, then we have to deal with it, no question about that.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3095#issuecomment-1010390366
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/issues/3095/1010390366 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220111/56b59366/attachment-0001.htm>