[Github-comments] [geany/geany] Crash after update to Scintilla 5.1.5 (Issue #3095)

[Thomas Martitz]

@techee so which part of d7c985e4741 do you think is faulty, exactly?

I changed `sci_get_text()` to account for scintilla writing 1 extra NUL byte, therefore I now pass `len - 1` to the API. The only in-core caller already allocates `sci_get_length() + 1` bytes. Also be aware that `sci_get_text()` is deprecated.

I think I made a mistake in `sci_get_contents()` for the `buffer_len < 0` case. `sci_get_string()` won't do the right thing. But correcting that does not fix the crash. The only 2 in-core callers do pass `-1` for `buffer_len` so the other case doesn't matter for the crash.

I'm not yet clear what exactly is causing the crash. At least the recipe provided by @elextr also crashes for me regularly.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3095#issuecomment-1010352238
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/issues/3095/1010352238 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20220111/29513db9/attachment.htm>