[Github-comments] [geany/geany-plugins] GeanyLua: Enable running scripts for all signals (#1112)

[elextr]

> If neither you nor @Skif-off are the plugin maintainer, the chances of this PR being merged is currently nil, regardless of the changes I might make.

Actually Geanylua is orphaned, see the [MAINTAINERS](https://github.com/geany/geany-plugins/blob/master/MAINTAINERS) file, so nobody is responsible for checking any changes to it.  Note its not the job of the collection maintainer to check unlike Geany itself.

But given that @Skif-off has made quite a number of contributions to the plugin, committers like me will probably defer to his advice.

> At this time, the estimated max number of users of this patch is 3. 

Yeah, with no spyware we don't know how many users there are for any Geany features or plugins, maybe we should add it. :smiling_imp:

> The scripts themselves should also be cached. 

Indeed, irrespective of the metadata examination cost, executing a script off disk for each keystroke is potentially a bigger issue.
 
I would have thought a normal design would have scripts executing off signals cached in memory by default, but I don't know how much effort that is for embedded Lua.  I don't expect scripts executing off Geany signals would be very large so memory usage should not be excessive.

Just a note that when we talk about remote filesystems, that includes network appliances and it surprised me that tens of millions of systems per annum were sold when last I looked.  So its likely not as rare as we think.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1112#issuecomment-934029686
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211004/e6ff8f96/attachment.htm>