<p></p>
<blockquote>
<p>If neither you nor <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/Skif-off/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Skif-off">@Skif-off</a> are the plugin maintainer, the chances of this PR being merged is currently nil, regardless of the changes I might make.</p>
</blockquote>
<p>Actually Geanylua is orphaned, see the <a href="https://github.com/geany/geany-plugins/blob/master/MAINTAINERS">MAINTAINERS</a> file, so nobody is responsible for checking any changes to it.  Note its not the job of the collection maintainer to check unlike Geany itself.</p>
<p>But given that <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/Skif-off/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Skif-off">@Skif-off</a> has made quite a number of contributions to the plugin, committers like me will probably defer to his advice.</p>
<blockquote>
<p>At this time, the estimated max number of users of this patch is 3.</p>
</blockquote>
<p>Yeah, with no spyware we don't know how many users there are for any Geany features or plugins, maybe we should add it. <g-emoji class="g-emoji" alias="smiling_imp" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f608.png">😈</g-emoji></p>
<blockquote>
<p>The scripts themselves should also be cached.</p>
</blockquote>
<p>Indeed, irrespective of the metadata examination cost, executing a script off disk for each keystroke is potentially a bigger issue.</p>
<p>I would have thought a normal design would have scripts executing off signals cached in memory by default, but I don't know how much effort that is for embedded Lua.  I don't expect scripts executing off Geany signals would be very large so memory usage should not be excessive.</p>
<p>Just a note that when we talk about remote filesystems, that includes network appliances and it surprised me that tens of millions of systems per annum were sold when last I looked.  So its likely not as rare as we think.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/1112#issuecomment-934029686">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ6YLGAOLNYEUYACJ2TUFJWVRANCNFSM5ENCRBVA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ4RV4WYZDYZXTESZYDUFJWVRA5CNFSM5ENCRBVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG6WCS5Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/pull/1112#issuecomment-934029686",
"url": "https://github.com/geany/geany-plugins/pull/1112#issuecomment-934029686",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>