[Github-comments] [geany/geany-plugins] GeanyLua: Enable running scripts for all signals (#1112)

xiota notifications at xxxxx
Tue Oct 5 00:58:03 UTC 2021


@elextr 

> ... the inode will be cached by Linux...
> But when the calls are not in the same closed loop the caching may not happen so well...

The inode will also be cached when even the slowest two-finger typists are actively typing.  The access time would have to measure over 100 ms to be noticeable to someone typing over 120wpm.  If that were to happen there is probably something else seriously wrong.

> or even not at all with some mount options.

What mount option?  In this case, the file simply does not exist, so there isn't even an atime to update.

> And for a remote file on a network (where the default is to ask for new metadata if the requests are more than 3 secs apart) there could be intermittent delays while typing.

I suppose someone forced to keep their Lua scripts on a high-latency remote server would have this problem.  In this case it's not enough to just check for file existence at startup.  The scripts themselves should also be cached.  I'm willing to work on this *if* I hear from someone with commit privileges.

> Since the cost is incurred only when the plugin is enabled, ultimately the decision is up to the the plugin maintainer, Geany doesn't really care.

I'm not inclined to make changes to fix hypothetical problems that no one will ever have.  At this time, the estimated max number of users of this patch is 3.  If neither you nor @Skif-off are the plugin maintainer, the chances of this PR being merged is currently nil.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1112#issuecomment-933972081
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211004/a6092019/attachment.htm>


More information about the Github-comments mailing list