[Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

[elextr]

> > @b4n now that you are returning nullptr from pixels() but you did not put a check for that on the return value of every use of pixels() all you have done is shift the problem. :stuck_out_tongue_winking_eye:

> Not really: at least to the C guy I am, reading 0 bytes from nullptr or 0 bytes from a valid pointer doesn't seem much different.

What I meant is that you are assuming that wherever the return pointer from `Pixels()` is used its not de-referenced for any reason, otherwise its a segfault or a UB.  I haven't traced all uses of the pointer `Pixels()` function returns to see, I just noticed your patch had no checks of the returned pointer.

Are you gonna post to Scintilla?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1041#issuecomment-740421120
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201207/5f3ec23e/attachment.htm>