[Github-comments] [geany/geany] "make check" unittests fail on Windows (#2677)

[Jiří Techet]

I have a suspect. I haven't checked exactly how we read the files for unit tests but it could be that we use MIO_FILE so the underlying OS implementation is taken. Microsoft documentation for fgets()

https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fgets-fgetws?view=msvc-160

says

```
...fgets reads characters from the current stream position to and including the first newline character...
```

and for `CRLF` line endings this means we could end with `CR` at the end of the line and then reading separate `LF`. (If this really is the case, it's just a purely idiotic way to implement this function.)




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2677#issuecomment-736338719
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201201/385c1f6d/attachment.htm>