<p></p>
<blockquote>
<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/b4n/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a> now that you are returning nullptr from pixels() but you did not put a check for that on the return value of every use of pixels() all you have done is shift the problem. <g-emoji class="g-emoji" alias="stuck_out_tongue_winking_eye" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f61c.png">😜</g-emoji></p>
</blockquote>
</blockquote>
<blockquote>
<p>Not really: at least to the C guy I am, reading 0 bytes from nullptr or 0 bytes from a valid pointer doesn't seem much different.</p>
</blockquote>
<p>What I meant is that you are assuming that wherever the return pointer from <code>Pixels()</code> is used its not de-referenced for any reason, otherwise its a segfault or a UB.  I haven't traced all uses of the pointer <code>Pixels()</code> function returns to see, I just noticed your patch had no checks of the returned pointer.</p>
<p>Are you gonna post to Scintilla?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/issues/1041#issuecomment-740421120">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ2R4EZYKNDNQQ6Q7PTSTXEXZANCNFSM4UHMIKQQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJYZHAWEAXC2KS623U3STXEXZA5CNFSM4UHMIKQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFQQ64AA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/issues/1041#issuecomment-740421120",
"url": "https://github.com/geany/geany-plugins/issues/1041#issuecomment-740421120",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>