[Github-comments] [geany/geany-plugins] geanypy: Use Python callback return value for keybindings return value (#809)

Colomban Wendling notifications at xxxxx
Fri Jan 4 23:13:32 UTC 2019


b4n commented on this pull request.



>  	Py_DECREF(args);
+	ret = (PyObject_IsTrue(py_ret) == 1);

The `==1` is to catch the `-1` on error, which should probably lead to returning `FALSE` rather than `TRUE`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/809#pullrequestreview-189561701
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190104/78f0e6f3/attachment.html>


More information about the Github-comments mailing list