<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/809#discussion_r245446778">geanypy/src/geanypy-keybindings.c</a>:</p>
<pre style='color:#555'>>      Py_DECREF(args);
+       ret = (PyObject_IsTrue(py_ret) == 1);
</pre>
<p>The <code>==1</code> is to catch the <code>-1</code> on error, which should probably lead to returning <code>FALSE</code> rather than <code>TRUE</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/809#pullrequestreview-189561701">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ69PEYp-YlEIpejasY5bPc_I_wLVks5u_-AcgaJpZM4ZuLmn">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJxbXBsPCcTFOxr33gbaEnE87W3WRks5u_-AcgaJpZM4ZuLmn.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #809"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/809#pullrequestreview-189561701"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/pull/809#pullrequestreview-189561701",
"url": "https://github.com/geany/geany-plugins/pull/809#pullrequestreview-189561701",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>