[Github-comments] [geany/geany-plugins] geanypy: Use Python callback return value for keybindings return value (#809)

Matthew Brush notifications at xxxxx
Sat Jan 5 02:21:04 UTC 2019


I haven't tested yet (on Windows ATM), but this is exactly what I was thinking to do.

The only question is whether the semantics make any sense, as in whether returning nothing in the Python function should default to returning `FALSE` to Geany. The [API Reference](https://www.geany.org/manual/reference/keybindings_8h.html#afb2861d240a298186fe4d84430e5066f) makes it sound like this is not the normal case.

It may be useful in either case to improve [the doctstrings](https://github.com/geany/geany-plugins/pull/809/files#diff-8c19fc53e5ac665274c8ae6877c63a84L145) to clarify this, as a separate change if need be.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/809#issuecomment-451620082
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190104/0c5af7a2/attachment-0001.html>


More information about the Github-comments mailing list