[Github-comments] [geany/geany] build: Split up build_load_menu() (#2272)

[Matthew Brush]

Not speaking to this PR itself, but in I tend to agree with @elextr in principle. A lot of Geany's code factoring is too granular and it makes it a pain to follow the flow when you have to keep jumping between short functions that do a small part of the overall goal. I don't think too many lines of code is - in and of itself - a valid reason to break up a function into smaller parts.

As discussed in the other PR, I'm also not a fond of short helper functions which do trivial stuff everyone already understands in order to save a few lines of code. Some examples I looked at recently are the `utils_free_pointers()` function and the `SETPTR()` macro. These just increase the mental overhead required to understand the code by having to know all these functions rather than just plain C stdlib or GLib.

Sorry I'm slightly off topic here, I haven't review the changes here yet to see whether it seems justified. Maybe we could work toward some guidelines on factoring of functions as a separate discussion.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2272#issuecomment-524573571
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190824/0f0fe2d7/attachment.html>