[Github-comments] [geany/geany] build: Split up build_load_menu() (#2272)

[elextr]

> Please avoid this kind of language, it makes me uncomfortable. It sounds like you are annoyed. Obviously I do not think it is a waste of time or I would not have submitted it. I often don't submit changes I have done that aren't of clear benefit to a project.

Programming is performed by people, and people have emotions.  In this case the emotion is exasperation not anger.  Geany is riddled with such spaghetti that divides simple linear code into sequential function calls and that makes it much harder to follow.  

Not every function is actually doing something short and simple, thats just life, and breaking such code into multiple parts makes it harder to follow.  

In this case the function of `build_load_menu` is "do this then do that", and your argument that one or two variables are not shared by `this` and `that` is irrelevant.

I'm sure we will continue to disagree on this, but thats life, @b4n will just have to keep adjudicating.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2272#issuecomment-524542814
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190824/10446102/attachment.html>