<p>Not speaking to this PR itself, but in I tend to agree with <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=811085" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a> in principle. A lot of Geany's code factoring is too granular and it makes it a pain to follow the flow when you have to keep jumping between short functions that do a small part of the overall goal. I don't think too many lines of code is - in and of itself - a valid reason to break up a function into smaller parts.</p>
<p>As discussed in the other PR, I'm also not a fond of short helper functions which do trivial stuff everyone already understands in order to save a few lines of code. Some examples I looked at recently are the <code>utils_free_pointers()</code> function and the <code>SETPTR()</code> macro. These just increase the mental overhead required to understand the code by having to know all these functions rather than just plain C stdlib or GLib.</p>
<p>Sorry I'm slightly off topic here, I haven't review the changes here yet to see whether it seems justified. Maybe we could work toward some guidelines on factoring of functions as a separate discussion.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2272?email_source=notifications&email_token=AAIOWJ7RMAIMNDSO5ZR4X6DQGGATPA5CNFSM4IPBGRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CFXAY#issuecomment-524573571">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJY5WRK6N4ODS5IWRVLQGGATPANCNFSM4IPBGRBQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ5GV3PUQMIR6LO7MBLQGGATPA5CNFSM4IPBGRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CFXAY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2272?email_source=notifications\u0026email_token=AAIOWJ7RMAIMNDSO5ZR4X6DQGGATPA5CNFSM4IPBGRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CFXAY#issuecomment-524573571",
"url": "https://github.com/geany/geany/pull/2272?email_source=notifications\u0026email_token=AAIOWJ7RMAIMNDSO5ZR4X6DQGGATPA5CNFSM4IPBGRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CFXAY#issuecomment-524573571",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>