[Github-comments] [geany/geany-plugins] scope: added GTK3 support (keeping GTK2 support) (#750)

[Colomban Wendling]

> ```
> GP_CHECK_GTK3([vte_package="vte >= 0.17"], [vte_package=vte-2.91])
> ```

This is swapped, [`GP_CHECK_GTK3`](https://github.com/geany/geany-plugins/blob/1.33.0/build/gtk.m4#L24) uses the first arg if GTK3 is used and the second otherwise.

> I'm not sure about the `vte >= 0.17` part in quotes

It should work

>, but I suppose at worst you could figure out what version is the earliest for `vte-2.91` and then have both branches do the version check like this (using `0.48` as example):

Yeah, anyway VTE version only grew, even with the newer ABI, so ` >= 0.17` will work fine with any of the ABI names, it'll just be moot for 2.91, but won't be a problem.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/750#issuecomment-394235485
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180603/38f69da6/attachment.html>