<blockquote>
<pre><code>GP_CHECK_GTK3([vte_package="vte >= 0.17"], [vte_package=vte-2.91])
</code></pre>
</blockquote>
<p>This is swapped, <a href="https://github.com/geany/geany-plugins/blob/1.33.0/build/gtk.m4#L24"><code>GP_CHECK_GTK3</code></a> uses the first arg if GTK3 is used and the second otherwise.</p>
<blockquote>
<p>I'm not sure about the <code>vte >= 0.17</code> part in quotes</p>
</blockquote>
<p>It should work</p>
<blockquote>
<p>, but I suppose at worst you could figure out what version is the earliest for <code>vte-2.91</code> and then have both branches do the version check like this (using <code>0.48</code> as example):</p>
</blockquote>
<p>Yeah, anyway VTE version only grew, even with the newer ABI, so <code>>= 0.17</code> will work fine with any of the ABI names, it'll just be moot for 2.91, but won't be a problem.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/750#issuecomment-394235485">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ3NYxgMLoPjqcfUjQbgsWjaPEHnZks5t5MCxgaJpZM4UYKVp">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ4ZdRurdIPyVggw74dkVX8UJ4pz7ks5t5MCxgaJpZM4UYKVp.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/geany/geany-plugins/pull/750#issuecomment-394235485","url":"https://github.com/geany/geany-plugins/pull/750#issuecomment-394235485","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #750: \u003e ```\r\n\u003e GP_CHECK_GTK3([vte_package=\"vte \u003e= 0.17\"], [vte_package=vte-2.91])\r\n\u003e ```\r\n\r\nThis is swapped, [`GP_CHECK_GTK3`](https://github.com/geany/geany-plugins/blob/1.33.0/build/gtk.m4#L24) uses the first arg if GTK3 is used and the second otherwise.\r\n\r\n\u003e I'm not sure about the `vte \u003e= 0.17` part in quotes\r\n\r\nIt should work\r\n\r\n\u003e, but I suppose at worst you could figure out what version is the earliest for `vte-2.91` and then have both branches do the version check like this (using `0.48` as example):\r\n\r\nYeah, anyway VTE version only grew, even with the newer ABI, so ` \u003e= 0.17` will work fine with any of the ABI names, it'll just be moot for 2.91, but won't be a problem."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/750#issuecomment-394235485"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [geany/geany-plugins] scope: added GTK3 support (keeping GTK2 support) (#750)",
"sections": [
{
"text": "",
"activityTitle": "**Colomban Wendling**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@b4n",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"issueId\": 750,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"geany/geany-plugins\",\n\"pullRequestId\": 750\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/geany/geany-plugins/pull/750#issuecomment-394235485"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 341878121\n}"
}
],
"themeColor": "26292E"
}</script>