[Github-comments] [geany/geany-plugins] scope: added GTK3 support (keeping GTK2 support) (#750)

[Matthew Brush]

I think you use the [`GP_CHECK_GTK3`](https://github.com/geany/geany-plugins/blob/1.33.0/build/gtk.m4#L24) macro [like this](https://github.com/geany/geany-plugins/blob/4039a13882f4b9e2127f6e7b018bdbdffe36e2a2/build/markdown.m4#L52).

Untested, but something like this I guess:

```
GP_CHECK_GTK3([vte_package="vte >= 0.17"], [vte_package=vte-2.91])
GP_CHECK_PLUGIN_DEPS([scope], [VTE], [$vte_package])
```

I'm not sure about the `vte >= 0.17` part in quotes, but I suppose at worst you could figure out what version is the earliest for `vte-2.91` and then have both branches do the version check like this (using `0.48` as example):

```
GP_CHECK_GTK3([
  vte_package=vte
  vte_version=0.17
], [
  vte_package=vte-2.91
  vte_version=0.48
])
GP_CHECK_PLUGIN_DEPS([scope], [VTE], [$vte_package >= $vte_version])
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/750#issuecomment-394186853
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180603/bc7981bc/attachment.html>