[Github-comments] [geany/geany-plugins] scope: added GTK3 support (keeping GTK2 support) (#750)

[LarsGit223]

This PR adds GTK3 support to the scope plugin, but still keeps GTK2 support (in contrast to PR #697).

Some compatibility code (macros) were put in the common utils lib so that other plugins can use it on porting to GTK3. So this PR includes changes on scope AND utils.

@frlan: don't merge this - it's work in progress.

But this is **NOT working** yet. **I need help** with the build system:

How can I make scope do the following:
If build against GTK2 use libvte0.17 or newer, e.g. like this:
```
            GP_CHECK_PLUGIN_DEPS([scope], [VTE],
                                 [vte >= 0.17])
```
If build against GTK3 use libvte2.91 or newer, e.g. like this:
```
            GP_CHECK_PLUGIN_DEPS([scope], [VTE],
                                 [vte-2.91])
```
Thanks for any help in advance.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/750

-- Commit Summary --

  * scope: added GTK3 support (keeping GTK2 support)

-- File Changes --

    M build/scope.m4 (1)
    M scope/src/Makefile.am (6)
    M scope/src/conterm.c (35)
    M scope/src/plugme.c (4)
    M scope/src/prefs.c (6)
    M scope/src/prefs.h (6)
    M scope/src/scope.c (4)
    M scope/src/utils.c (11)
    M utils/src/Makefile.am (9)
    A utils/src/gp_gtkcompat.h (57)
    A utils/src/gp_vtecompat.c (47)
    A utils/src/gp_vtecompat.h (60)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/750.patch
https://github.com/geany/geany-plugins/pull/750.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/750
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20180603/def71f60/attachment.html>