[Github-comments] [geany/geany] Proxy Plugins Filename Pattern Matching (#1236)

[Thomas Martitz]

Am 24.10.2016 um 21:27 schrieb Matthew Brush:
>     It was suggested by you or maybe b4n
>
> Ah right, I made a PR for it <https://github.com/kugel-/geany/pull/3>,
> but you closed without merging my commits.


You suggested to not merge it until an actual use case arises.


>
> Still I don't really see what it buys you, the example proxy change
> would then look like this instead of above:
>
> ...
>   const gchar *patterns[4] = { NULL };
>   if (geany_api_version() >= 230)
>   {
>     patterns[0] = "*.so";
>     patterns[1] = "*.dll";
>     patterns[2] = "*.plugin";
>   }
>   else
>   {
>     patterns[0] = "so";
>     patterns[1] = "dll";
>     patterns[2] = "plugin";
>   }
>   geany_plugin_register_proxy(plugin, patterns);
> ...
>
> Not really an improvement over just using |GEANY_API_VERSION| with the
> preprocessor, unless I misunderstand?
>


The improvement is you can upgrade Geany without recompiling Peasy. But 
if yea, if the ABI version is changed it needs to be recompiled anyway.

I simply would like to avoid having to recompile Peasy between 1.28 and 
1.29, but don't mind if it's too much work.

Best regards



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1236#issuecomment-256136273
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161025/0640e112/attachment.html>